From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
horia.geanta@nxp.com
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v5 0/4] Additional fixes on Talitos driver
Date: Tue, 2 Jul 2019 11:23:22 +0200 [thread overview]
Message-ID: <e011f5a3-2be3-90c9-4723-a2b16d6d56ac@c-s.fr> (raw)
In-Reply-To: <cover.1561360551.git.christophe.leroy@c-s.fr>
Hi Herbert,
Le 24/06/2019 à 09:21, Christophe Leroy a écrit :
> This series is the last set of fixes for the Talitos driver.
Do you plan to apply this series, or are you expecting anythink from
myself ?
Thanks
Christophe
>
> We now get a fully clean boot on both SEC1 (SEC1.2 on mpc885) and
> SEC2 (SEC2.2 on mpc8321E) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS:
>
> [ 3.385197] bus: 'platform': really_probe: probing driver talitos with device ff020000.crypto
> [ 3.450982] random: fast init done
> [ 12.252548] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna)
> [ 12.262226] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna)
> [ 43.310737] Bug in SEC1, padding ourself
> [ 45.603318] random: crng init done
> [ 54.612333] talitos ff020000.crypto: fsl,sec1.2 algorithms registered in /proc/crypto
> [ 54.620232] driver: 'talitos': driver_bound: bound to device 'ff020000.crypto'
>
> [ 1.193721] bus: 'platform': really_probe: probing driver talitos with device b0030000.crypto
> [ 1.229197] random: fast init done
> [ 2.714920] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos)
> [ 2.724312] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos-hsna)
> [ 4.482045] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos)
> [ 4.490940] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna)
> [ 4.500280] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos)
> [ 4.509727] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna)
> [ 6.631781] random: crng init done
> [ 11.521795] talitos b0030000.crypto: fsl,sec2.2 algorithms registered in /proc/crypto
> [ 11.529803] driver: 'talitos': driver_bound: bound to device 'b0030000.crypto'
>
> v2: dropped patch 1 which was irrelevant due to a rebase weirdness. Added Cc to stable on the 2 first patches.
>
> v3:
> - removed stable reference in patch 1
> - reworded patch 1 to include name of patch 2 for the dependency.
> - mentionned this dependency in patch 2 as well.
> - corrected the Fixes: sha1 in patch 4
>
> v4:
> - using scatterwalk_ffwd() instead of opencodying SG list forwarding.
> - Added a patch to fix sg_copy_to_buffer() when sg->offset() is greater than PAGE_SIZE,
> otherwise sg_copy_to_buffer() fails when the list has been forwarded with scatterwalk_ffwd().
> - taken the patch "crypto: talitos - eliminate unneeded 'done' functions at build time"
> out of the series because it is independent.
> - added a helper to find the header field associated to a request in flush_channe()
>
> v5:
> - Replacing the while loop by a direct shift/mask operation, as suggested by Herbert in patch 1.
>
> Christophe Leroy (4):
> lib/scatterlist: Fix mapping iterator when sg->offset is greater than
> PAGE_SIZE
> crypto: talitos - move struct talitos_edesc into talitos.h
> crypto: talitos - fix hash on SEC1.
> crypto: talitos - drop icv_ool
>
> drivers/crypto/talitos.c | 102 +++++++++++++++++++----------------------------
> drivers/crypto/talitos.h | 28 +++++++++++++
> lib/scatterlist.c | 9 +++--
> 3 files changed, 74 insertions(+), 65 deletions(-)
>
next prev parent reply other threads:[~2019-07-02 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 7:20 [PATCH v5 0/4] *** SUBJECT HERE *** Christophe Leroy
2019-06-24 7:20 ` [PATCH v5 1/4] lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE Christophe Leroy
2019-06-24 7:20 ` [PATCH v5 2/4] crypto: talitos - move struct talitos_edesc into talitos.h Christophe Leroy
2019-06-24 7:20 ` [PATCH v5 3/4] crypto: talitos - fix hash on SEC1 Christophe Leroy
2019-06-24 7:20 ` [PATCH v5 4/4] crypto: talitos - drop icv_ool Christophe Leroy
2019-06-24 7:21 ` [PATCH v5 0/4] Additional fixes on Talitos driver Christophe Leroy
2019-07-02 9:23 ` Christophe Leroy [this message]
2019-07-03 14:27 ` [PATCH v5 0/4] *** SUBJECT HERE *** Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e011f5a3-2be3-90c9-4723-a2b16d6d56ac@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).