From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FE30C433F5 for ; Thu, 17 Feb 2022 20:01:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245624AbiBQUBs (ORCPT ); Thu, 17 Feb 2022 15:01:48 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245611AbiBQUBp (ORCPT ); Thu, 17 Feb 2022 15:01:45 -0500 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 327FE189; Thu, 17 Feb 2022 12:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1645128090; x=1676664090; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Y878BkAU96m4bDN8k2wpI4BUoj/vtOIuveF4X6o8gqg=; b=mDNhHHqApHJE1KjOdIr/+vToNHHWfAn3NdGuEv4fONiARj5oe9T7SAYr lf6feUTzIaH2AMFIeOKMFKDCNr+H6TKXEyyyzq7wnbyqWnTT0B4OQvDEd EEr/6K5OrNYBU6hZXBuuQACwlGGSSZN1gYN+BfcIQlGE8b+kZ1yW8oLgz A=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 17 Feb 2022 12:01:29 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2022 12:01:29 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Thu, 17 Feb 2022 12:01:28 -0800 Received: from [10.110.101.104] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Thu, 17 Feb 2022 12:01:27 -0800 Message-ID: Date: Thu, 17 Feb 2022 12:01:26 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 3/3] drm/msm/dp: replace DRM_DEBUG_DP marco with drm_dbg_dp Content-Language: en-US To: Stephen Boyd , , , , , , , , , CC: , , , , , References: <1645122930-23863-1-git-send-email-quic_khsieh@quicinc.com> <1645122930-23863-4-git-send-email-quic_khsieh@quicinc.com> From: Kuogee Hsieh In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/17/2022 11:36 AM, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2022-02-17 10:35:30) >> Since DRM_DEBUG_DP is deprecated in favor of drm_dbg_dp(NULL, ...), >> this patch replace all DRM_DEBUG_DP with drm_dbg_dp(). >> >> Changes in v4: >> -- replace (strucr drm_dev *)NULL with drm_dev > Why can't the platform device be used? #define drm_dbg_dp(drm, fmt, ...)                                       \         drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_DP, fmt, ##__VA_ARGS__) it looks for (drm)->dev (pointer) struct platform_device {         const char      *name;         int             id;         bool            id_auto;         struct device   dev          <== not an pointer here