From: Coly Li <colyli@suse.de>
To: Zhiqiang Liu <liuzhiqiang26@huawei.com>,
kmo@daterainc.com, linux-bcache@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "wubo (T)" <wubo40@huawei.com>,
Mingfangsen <mingfangsen@huawei.com>,
Yanxiaodan <yanxiaodan@huawei.com>,
linfeilong <linfeilong@huawei.com>,
renxudong <renxudong1@huawei.com>
Subject: Re: [PATCH V2] bcache: fix potential deadlock problem in btree_gc_coalesce
Date: Sun, 26 Apr 2020 17:36:35 +0800 [thread overview]
Message-ID: <e01be1b7-e59c-24e2-3923-917d27fa097a@suse.de> (raw)
In-Reply-To: <8a6f5fe3-33f9-48e2-e347-05781c3295fd@huawei.com>
On 2020/4/26 16:06, Zhiqiang Liu wrote:
> From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>
> coccicheck reports:
> drivers/md//bcache/btree.c:1538:1-7: preceding lock on line 1417
>
> btree_gc_coalesce func is designed to coalesce two adjacent nodes in
> new_nodes[GC_MERGE_NODES] and finally release one node. All nodes`write_lock,
> new_nodes[i]->write_lock, are holded before coalescing adjacent nodes,
> and them will be released after coalescing successfully.
>
> However, if the coalescing process fails, such as no enough space of new_nodes[1]
> to fit all of the remaining keys in new_nodes[0] and realloc keylist failed, we
> will goto to out_nocoalesce tag directly without releasing new_nodes[i]->write_lock.
> Then, a deadlock will occur after calling btree_node_free to free new_nodes[i],
> which also try to acquire new_nodes[i]->write_lock.
>
> Here, we add a new tag 'out_unlock_nocoalesce' before out_nocoalesce tag to release
> new_nodes[i]->write_lock when coalescing process fails.
>
> --
> V1->V2: rewrite commit log (suggested by Coly Li) and rename the patch
>
> Fixes: 2a285686c1 ("bcache: btree locking rework")
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
OK, I will add it to my for-test queue.
Thanks.
Coly Li
> ---
> drivers/md/bcache/btree.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index fa872df4e770..cad8b0b97e33 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -1447,7 +1447,7 @@ static int btree_gc_coalesce(struct btree *b, struct btree_op *op,
> if (__set_blocks(n1, n1->keys + n2->keys,
> block_bytes(b->c)) >
> btree_blocks(new_nodes[i]))
> - goto out_nocoalesce;
> + goto out_unlock_nocoalesce;
>
> keys = n2->keys;
> /* Take the key of the node we're getting rid of */
> @@ -1476,7 +1476,7 @@ static int btree_gc_coalesce(struct btree *b, struct btree_op *op,
>
> if (__bch_keylist_realloc(&keylist,
> bkey_u64s(&new_nodes[i]->key)))
> - goto out_nocoalesce;
> + goto out_unlock_nocoalesce;
>
> bch_btree_node_write(new_nodes[i], &cl);
> bch_keylist_add(&keylist, &new_nodes[i]->key);
> @@ -1522,6 +1522,10 @@ static int btree_gc_coalesce(struct btree *b, struct btree_op *op,
> /* Invalidated our iterator */
> return -EINTR;
>
> +out_unlock_nocoalesce:
> + for (i = 0; i < nodes; i++)
> + mutex_unlock(&new_nodes[i]->write_lock);
> +
> out_nocoalesce:
> closure_sync(&cl);
>
next prev parent reply other threads:[~2020-04-26 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 8:06 [PATCH V2] bcache: fix potential deadlock problem in btree_gc_coalesce Zhiqiang Liu
2020-04-26 9:36 ` Coly Li [this message]
2020-04-26 18:16 Markus Elfring
2020-06-12 1:01 ` Zhiqiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e01be1b7-e59c-24e2-3923-917d27fa097a@suse.de \
--to=colyli@suse.de \
--cc=kmo@daterainc.com \
--cc=linfeilong@huawei.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=mingfangsen@huawei.com \
--cc=renxudong1@huawei.com \
--cc=wubo40@huawei.com \
--cc=yanxiaodan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).