From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD916C433F5 for ; Sun, 2 Oct 2022 16:11:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230032AbiJBQLx (ORCPT ); Sun, 2 Oct 2022 12:11:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230014AbiJBQLu (ORCPT ); Sun, 2 Oct 2022 12:11:50 -0400 Received: from smtp.smtpout.orange.fr (smtp08.smtpout.orange.fr [80.12.242.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7805829CB7 for ; Sun, 2 Oct 2022 09:11:48 -0700 (PDT) Received: from [192.168.1.18] ([86.243.100.34]) by smtp.orange.fr with ESMTPA id f1ZBo06ecJvOZf1ZBo73Xc; Sun, 02 Oct 2022 18:11:46 +0200 X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 02 Oct 2022 18:11:46 +0200 X-ME-IP: 86.243.100.34 Message-ID: Date: Sun, 2 Oct 2022 18:11:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v6 1/3] iio: temperature: mlx90632 Add runtime powermanagement modes Content-Language: fr To: cmo@melexis.com Cc: andy.shevchenko@gmail.com, jic23@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Newsgroups: gmane.linux.kernel.iio,gmane.linux.kernel References: From: Christophe JAILLET In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 02/10/2022 à 18:09, Christophe JAILLET a écrit : >>   static int mlx90632_read_raw(struct iio_dev *indio_dev, >>                    struct iio_chan_spec const *channel, int *val, >>                    int *val2, long mask) >>   { >>       struct mlx90632_data *data = iio_priv(indio_dev); >>       int ret; >> +    int cr; > > This 'cr' seems to be unused. Ok, used in patch 2/3. Sorry for the noise. CJ > >> + >> +    pm_runtime_get_sync(&data->client->dev); >> +    ret = mlx90632_pm_interraction_wakeup(data); >> +    if (ret < 0) >> +        goto mlx90632_read_raw_pm; > > [...] > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A6C9C433FE for ; Sun, 2 Oct 2022 16:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230016AbiJBQL6 (ORCPT ); Sun, 2 Oct 2022 12:11:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229754AbiJBQLy (ORCPT ); Sun, 2 Oct 2022 12:11:54 -0400 Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E59829C81 for ; Sun, 2 Oct 2022 09:11:53 -0700 (PDT) Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1of1ZF-0003iV-N7 for linux-kernel@vger.kernel.org; Sun, 02 Oct 2022 18:11:49 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: linux-kernel@vger.kernel.org From: Christophe JAILLET Subject: Re: [PATCH v6 1/3] iio: temperature: mlx90632 Add runtime powermanagement modes Date: Sun, 2 Oct 2022 18:11:44 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: linux-iio@vger.kernel.org Content-Language: fr In-Reply-To: Cc: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20221002161144.AaJr1fdDgNAOlCNpQ-wP6V0Jpnv1_9lGLqeN3_oY3wQ@z> Le 02/10/2022 à 18:09, Christophe JAILLET a écrit : >>   static int mlx90632_read_raw(struct iio_dev *indio_dev, >>                    struct iio_chan_spec const *channel, int *val, >>                    int *val2, long mask) >>   { >>       struct mlx90632_data *data = iio_priv(indio_dev); >>       int ret; >> +    int cr; > > This 'cr' seems to be unused. Ok, used in patch 2/3. Sorry for the noise. CJ > >> + >> +    pm_runtime_get_sync(&data->client->dev); >> +    ret = mlx90632_pm_interraction_wakeup(data); >> +    if (ret < 0) >> +        goto mlx90632_read_raw_pm; > > [...] >