From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8813CC070C3 for ; Mon, 15 Oct 2018 03:21:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3318D20842 for ; Mon, 15 Oct 2018 03:21:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sLmS7sgM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3318D20842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726528AbeJOLEW (ORCPT ); Mon, 15 Oct 2018 07:04:22 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:32959 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726262AbeJOLEW (ORCPT ); Mon, 15 Oct 2018 07:04:22 -0400 Received: by mail-pf1-f195.google.com with SMTP id 78-v6so6550890pfq.0; Sun, 14 Oct 2018 20:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4aF6c9JbvpH1PKbxxpCn88IfRAjR/ztFrYMFBZ+rTg0=; b=sLmS7sgMLX974RGRayN+6vztFOpfK9eaY5nwvJjCcUM/zoAZccFbVhZPi3nA9GsAqr Mf/RxgXy6gd1t3qO5wtEs4ZuKcYo1vW6RHQR89E64uzT91pOwMYIKg4sixIn7eIoyonF W9dYfQfQd/2vorn/thyhlPfgWjuZuT5oU7IjRkcJ5Dmkad/ORVGgn+tBifiOj734wan3 0Oq2ubMggw2SHVLwo0LBt1zPKV3TuSCgJ96uqZytrkES8oco/8Bx5ZEzzbiBTKYGgEcI Yce1PVUPj+xBjdK1fytAcXNVAvIAI5OTN9OXXwdujCnZHQAXauUihaJXwUssHvHvWfCx 5sjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4aF6c9JbvpH1PKbxxpCn88IfRAjR/ztFrYMFBZ+rTg0=; b=N/PdMWI6HsZFYGx1mRLleTdj0lMltQpR+wFm2PSnchiPS3mc/q1jeNg7ASQ0j3VBO9 63Whz2w1Q/Jbe2e/YhbumGkJCMbXS8QK8hxQxXl1Tf1hrW0ba9jfskRtIj40IGwDQfZF PsU1GzO0gZPJWUml/dLR3MAF5T+pIER6LTCjw++/Y3N2U6IbL2af4HJH/Sn6G7U1RMmV pX3SU3aFd8eNsakfddkcYJnm49FZEhesWnww7U2wjp4E+ffWaEIRjjzcba9BRxbAnV/Y Qji2W/PPFgpN+u3OXVP6VQKozgrfuYsJ4bYWIZuXI+0cUAi0dipeLpCzDC+IZuG+BhCp WR+g== X-Gm-Message-State: ABuFfogSSpN8AVK1xDo3a3ZGVUuxdTJ9qKtH/j3j3qgViZKeMAqVOfgG czjORqDaHyVVTAKHxaVMwyo= X-Google-Smtp-Source: ACcGV63ZaGG/lmONYDZGCa+McbcB5tPxOz0LbLXe/zyr3p9Hc8MXEAiYIN0ry7jutrKFYOpD6ytyVw== X-Received: by 2002:a65:40c2:: with SMTP id u2-v6mr14468908pgp.123.1539573663420; Sun, 14 Oct 2018 20:21:03 -0700 (PDT) Received: from [192.168.1.70] (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id m15-v6sm15633236pgt.28.2018.10.14.20.21.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Oct 2018 20:21:02 -0700 (PDT) Subject: Re: [PATCH v3 13/18] of: overlay: check prevents multiple fragments touching same property To: Joe Perches , Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org References: <1539563070-12969-1-git-send-email-frowand.list@gmail.com> <1539563070-12969-14-git-send-email-frowand.list@gmail.com> <850f0866-1189-5a49-01c5-79caf270abbd@gmail.com> <16f48648393366d91e43cd66b3d0a346b1ed29ab.camel@perches.com> From: Frank Rowand Message-ID: Date: Sun, 14 Oct 2018 20:21:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <16f48648393366d91e43cd66b3d0a346b1ed29ab.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/18 18:55, Joe Perches wrote: > On Sun, 2018-10-14 at 18:52 -0700, Frank Rowand wrote: >> On 10/14/18 18:06, Joe Perches wrote: >>> On Sun, 2018-10-14 at 17:24 -0700, frowand.list@gmail.com wrote: >>>> From: Frank Rowand >>>> >>>> Add test case of two fragments updating the same property. After >>>> adding the test case, the system hangs at end of boot, after >>>> after slub stack dumps from kfree() in crypto modprobe code. > [] >>> I think this is worse performance than before. >>> >>> This now walks all entries when before it would >>> return -EINVAL directly when it found a match. >> >> Yes, it is worse performance, but that is OK. >> >> This is a check that is done when a devicetree overlay is applied. >> If an error occurs then that means that the overlay was incorrectly >> specified. The file drivers/of/unittest-data/overlay_bad_add_dup_prop.dts >> in this patch provides an example of how a bad overlay can be created. >> >> Once an error was detected, the check could return immediately, or it >> could continue to give a complete list of detected errors. I chose to >> give the complete list of detected errors. > > Swell. Please describe that in the commit message. If a version 4 of the series is created I will update the commit message. As a stand alone item I do not think it is worth a new version. -Frank