From: Matthias Brugger <matthias.bgg@gmail.com>
To: James Liao <jamesjj.liao@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: dts: mt8183: Enable CPU idle-states
Date: Tue, 14 Jan 2020 12:14:30 +0100 [thread overview]
Message-ID: <e046d80c-07fb-7d45-309e-6f55dd8b0dc2@gmail.com> (raw)
In-Reply-To: <1578996673-8140-1-git-send-email-jamesjj.liao@mediatek.com>
On 14/01/2020 11:11, James Liao wrote:
> Enable mcdi-cpu and mcdi-cluster on MT8183 CPUs.
>
> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
> ---
> This patch bases on v5.5-rc6, adds idle-states for MT8183 CPUs.
>
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 10b3247..a022325 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -73,6 +73,7 @@
> reg = <0x000>;
> enable-method = "psci";
> capacity-dmips-mhz = <741>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu1: cpu@1 {
> @@ -81,6 +82,7 @@
> reg = <0x001>;
> enable-method = "psci";
> capacity-dmips-mhz = <741>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu2: cpu@2 {
> @@ -89,6 +91,7 @@
> reg = <0x002>;
> enable-method = "psci";
> capacity-dmips-mhz = <741>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu3: cpu@3 {
> @@ -97,6 +100,7 @@
> reg = <0x003>;
> enable-method = "psci";
> capacity-dmips-mhz = <741>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu4: cpu@100 {
> @@ -105,6 +109,7 @@
> reg = <0x100>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu5: cpu@101 {
> @@ -113,6 +118,7 @@
> reg = <0x101>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu6: cpu@102 {
> @@ -121,6 +127,7 @@
> reg = <0x102>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> };
>
> cpu7: cpu@103 {
> @@ -129,6 +136,29 @@
> reg = <0x103>;
> enable-method = "psci";
> capacity-dmips-mhz = <1024>;
> + cpu-idle-states = <&MCDI_CPU &MCDI_CLUSTER>;
> + };
> +
> + idle-states {
> + entry-method = "arm,psci";
reading idle-states.txt the entry-method should be "psci".
> +
> + MCDI_CPU: mcdi-cpu {
I wonder what MCDI stands for. Normally we have CPU_SLEEP and CLUSTER_SLEEP here.
Regards,
Matthias
> + compatible = "arm,idle-state";
> + local-timer-stop;
> + arm,psci-suspend-param = <0x00010001>;
> + entry-latency-us = <200>;
> + exit-latency-us = <200>;
> + min-residency-us = <800>;
> + };
> +
> + MCDI_CLUSTER: mcdi-cluster {
> + compatible = "arm,idle-state";
> + local-timer-stop;
> + arm,psci-suspend-param = <0x01010001>;
> + entry-latency-us = <250>;
> + exit-latency-us = <400>;
> + min-residency-us = <1300>;
> + };
> };
> };
>
>
next prev parent reply other threads:[~2020-01-14 11:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 10:11 [PATCH v2] arm64: dts: mt8183: Enable CPU idle-states James Liao
2020-01-14 11:14 ` Matthias Brugger [this message]
2020-01-15 5:32 ` James Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e046d80c-07fb-7d45-309e-6f55dd8b0dc2@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jamesjj.liao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).