From: "H. Peter Anvin" <hpa@zytor.com>
To: Daniel Kiper <daniel.kiper@oracle.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, xen-devel@lists.xenproject.org
Cc: ard.biesheuvel@linaro.org, boris.ostrovsky@oracle.com,
bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com,
luto@kernel.org, peterz@infradead.org, eric.snowberg@oracle.com,
jgross@suse.com, kanth.ghatraju@oracle.com,
konrad.wilk@oracle.com, mingo@redhat.com, rdunlap@infradead.org,
ross.philipson@oracle.com, tglx@linutronix.de
Subject: Re: [PATCH v4 2/3] x86/boot: Introduce the kernel_info.setup_type_max
Date: Fri, 1 Nov 2019 13:55:57 -0700 [thread overview]
Message-ID: <e094a1cf-6bf2-1e8a-94c7-47767d66138e@zytor.com> (raw)
In-Reply-To: <20191024114814.6488-3-daniel.kiper@oracle.com>
On 2019-10-24 04:48, Daniel Kiper wrote:
> This field contains maximal allowed type for setup_data.
>
> Now bump the setup_header version in arch/x86/boot/header.S.
Please don't bump the protocol revision here, otherwise we would create
a very odd pseudo-revision of the protocol: 2.15 without SETUP_INDIRECT
support, should patch 3/3 end up getting reverted.
(It is possible to detect, of course, but I feel pretty sure in saying
that bootloaders won't get it right.)
Other than that:
Reviewed-by: H. Peter Anvin (Intel) <hpa@zytor.com>
-hpa
next prev parent reply other threads:[~2019-11-01 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 11:48 [PATCH v4 0/3] x86/boot: Introduce the kernel_info et consortes Daniel Kiper
2019-10-24 11:48 ` [PATCH v4 1/3] x86/boot: Introduce the kernel_info Daniel Kiper
2019-10-24 11:48 ` [PATCH v4 2/3] x86/boot: Introduce the kernel_info.setup_type_max Daniel Kiper
2019-11-01 20:55 ` H. Peter Anvin [this message]
2019-11-04 15:16 ` Daniel Kiper
2019-10-24 11:48 ` [PATCH v4 3/3] x86/boot: Introduce the setup_indirect Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e094a1cf-6bf2-1e8a-94c7-47767d66138e@zytor.com \
--to=hpa@zytor.com \
--cc=ard.biesheuvel@linaro.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel.kiper@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=eric.snowberg@oracle.com \
--cc=jgross@suse.com \
--cc=kanth.ghatraju@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=ross.philipson@oracle.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).