From: Randy Dunlap <rdunlap@infradead.org>
To: Cai Huoqing <caihuoqing@baidu.com>,
sylvester.nawrocki@gmail.com, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: s3c-camif: Remove unused including <linux/version.h>
Date: Tue, 27 Jul 2021 13:52:06 -0700 [thread overview]
Message-ID: <e09e8157-ff37-ba76-49a8-c6c2f84725b4@infradead.org> (raw)
In-Reply-To: <20210727054032.760-1-caihuoqing@baidu.com>
On 7/26/21 10:40 PM, Cai Huoqing wrote:
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
as reported by 'make versioncheck':
../drivers/media/platform/s3c-camif/camif-core.c: 26 linux/version.h not needed.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
thanks.
> ---
> drivers/media/platform/s3c-camif/camif-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c
> index e1d51fd3e700..64078cbfd7f9 100644
> --- a/drivers/media/platform/s3c-camif/camif-core.c
> +++ b/drivers/media/platform/s3c-camif/camif-core.c
> @@ -23,7 +23,6 @@
> #include <linux/pm_runtime.h>
> #include <linux/slab.h>
> #include <linux/types.h>
> -#include <linux/version.h>
>
> #include <media/media-device.h>
> #include <media/v4l2-ctrls.h>
>
--
~Randy
prev parent reply other threads:[~2021-07-27 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 5:40 [PATCH] media: s3c-camif: Remove unused including <linux/version.h> Cai Huoqing
2021-07-27 20:52 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e09e8157-ff37-ba76-49a8-c6c2f84725b4@infradead.org \
--to=rdunlap@infradead.org \
--cc=caihuoqing@baidu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).