From: Rafael David Tinoco <rafael.tinoco@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org>
Cc: Rafael David Tinoco <rafael.tinoco@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
rui.zhang@intel.com, edubezval@gmail.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: v4.14 fix for Hikey 960 unbalanced IRQ enablement
Date: Mon, 3 Dec 2018 16:24:48 -0200 [thread overview]
Message-ID: <e0eb7f46-e619-7198-eb78-2b55246b1159@linaro.org> (raw)
In-Reply-To: <20181203180521.GA15996@kroah.com>
>> Greg,
>>
>> Patch 5 in this series seems to explain the best what is happening here:
>>
>>> With the following changes, we fix all in one:
>>>
>>> - Do the setup, one time, at probe time
>>>
>>> - Add the IRQF_ONESHOT, ack the interrupt in the threaded handler
>>>
>>> - Remove the interrupt handler
>>>
>>> - Set the correct value for the LAG register
>>>
>>> - Remove all the irq_enabled stuff in the code as the interruption
>>> handling is fixed
>>>
>>> - Remove the 3ms delay
>>>
>>> - Reorder the initialization routine to be in the right order
>>
>> We can't revert anything because the breakage was there since the driver
>> was introduced.
>
> So the driver was broken in 4.14, why not just use 4.19 instead? This
> isn't a 4.14 regression, it's something that obviously no one has
> noticed for a year now, so why backport these big patches to 4.14 now?
>
> thanks,
>
> greg k-h
>
This was caught during our functional tests. No direct complains, but,
since it included a trace, and there was a fix for it, I thought it
could be accepted for upstream v4.14 (it is included in other v4.14
kernels, like Android's).
thanks!
--
Rafael D. Tinoco
Linaro - Kernel Validation
next prev parent reply other threads:[~2018-12-03 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 13:31 v4.14 fix for Hikey 960 unbalanced IRQ enablement Rafael David Tinoco
2018-12-03 13:31 ` [PATCH 1/5] thermal/drivers/hisi: Remove the multiple sensors support Rafael David Tinoco
2018-12-03 13:31 ` [PATCH 2/5] thermal/drivers/hisi: Remove pointless lock Rafael David Tinoco
2018-12-03 13:31 ` [PATCH 3/5] thermal/drivers/hisi: Encapsulate register writes into helpers Rafael David Tinoco
2018-12-03 13:31 ` [PATCH 4/5] thermal/drivers/hisi: Fix configuration register setting Rafael David Tinoco
2018-12-03 13:31 ` [PATCH 5/5] thermal/drivers/hisi: Remove costly sensor inspection Rafael David Tinoco
2018-12-03 14:14 ` v4.14 fix for Hikey 960 unbalanced IRQ enablement Greg KH
2018-12-03 14:42 ` Daniel Lezcano
2018-12-03 15:19 ` Sasha Levin
2018-12-03 18:05 ` Greg KH
2018-12-03 18:24 ` Rafael David Tinoco [this message]
2018-12-06 11:05 ` Greg KH
2018-12-03 18:33 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0eb7f46-e619-7198-eb78-2b55246b1159@linaro.org \
--to=rafael.tinoco@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).