From: Daniel Wagner <daniel.wagner@bmw-carit.de>
To: Steven Rostedt <rostedt@goodmis.org>,
Binoy Jayan <binoy.jayan@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
<linaro-kernel@lists.linaro.org>, Carsten Emde <C.Emde@osadl.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Masami <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints
Date: Tue, 30 Aug 2016 17:02:03 +0200 [thread overview]
Message-ID: <e0ec2448-6460-7b84-084d-f59dbd9604e5@bmw-carit.de> (raw)
In-Reply-To: <498d04b6-a0ac-1442-9c65-154f5c4923be@bmw-carit.de>
On 08/30/2016 04:20 PM, Daniel Wagner wrote:
> Just setting the size of the type is not enough. The hist_field_*
> getter function want to know the offset too:
With this hack here it should work. The COMM generic field is handled via
the tracing_map_ops. We could do it also there but than we need to
a condition in the trace_map_ops if it is COMM or CPU.
This shortcut here avoids it:
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 03c0a48..ab8958f 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -152,7 +152,8 @@ EXPORT_SYMBOL_GPL(trace_define_field);
#define __generic_field(type, item, filter_type) \
ret = __trace_define_field(&ftrace_generic_fields, #type, \
- #item, 0, 0, is_signed_type(type), \
+ #item, 0, sizeof(type), \
+ is_signed_type(type), \
filter_type); \
if (ret) \
return ret;
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index f3a960e..77073b7 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -75,6 +75,11 @@ static u64 hist_field_log2(struct hist_field *hist_field, void *event)
return (u64) ilog2(roundup_pow_of_two(val));
}
+static u64 hist_field_cpu(struct hist_field *hist_field, void *event)
+{
+ return (u64) smp_processor_id();
+}
+
#define DEFINE_HIST_FIELD_FN(type) \
static u64 hist_field_##type(struct hist_field *hist_field, void *event)\
{ \
@@ -119,6 +124,7 @@ enum hist_field_flags {
HIST_FIELD_FL_SYSCALL = 128,
HIST_FIELD_FL_STACKTRACE = 256,
HIST_FIELD_FL_LOG2 = 512,
+ HIST_FIELD_FL_CPU = 1024,
};
struct hist_trigger_attrs {
@@ -371,6 +377,11 @@ static struct hist_field *create_hist_field(struct ftrace_event_field *field,
goto out;
}
+ if (flags & HIST_FIELD_FL_CPU) {
+ hist_field->fn = hist_field_cpu;
+ goto out;
+ }
+
if (WARN_ON_ONCE(!field))
goto out;
@@ -556,6 +567,11 @@ static int create_key_field(struct hist_trigger_data *hist_data,
key_size = MAX_FILTER_STR_VAL;
else
key_size = field->size;
+
+ // strcmp(field_name, "cpu") would also work to figure
+ // out if this is a one of the generic fields.
+ if (field->filter_type == FILTER_CPU)
+ flags |= HIST_FIELD_FL_CPU;
}
hist_data->fields[key_idx] = create_hist_field(field, flags);
next prev parent reply other threads:[~2016-08-30 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 6:55 [PATCH v3 0/3] *** Latency histograms - IRQSOFF,PREEMPTOFF *** Binoy Jayan
2016-08-29 6:55 ` [PATCH v3 1/3] tracing: Deference pointers without RCU checks Binoy Jayan
2016-08-29 6:55 ` [PATCH v3 2/3] tracing: Add trace_irqsoff tracepoints Binoy Jayan
2016-08-29 9:43 ` Daniel Wagner
2016-08-30 9:41 ` Binoy Jayan
2016-08-30 13:52 ` Steven Rostedt
2016-08-30 14:01 ` Daniel Wagner
2016-08-30 14:20 ` Daniel Wagner
2016-08-30 15:02 ` Daniel Wagner [this message]
2016-08-30 21:06 ` Steven Rostedt
2016-08-31 6:05 ` Binoy Jayan
2016-08-29 6:55 ` [PATCH v3 3/3] tracing: Histogram for missed timer offsets Binoy Jayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0ec2448-6460-7b84-084d-f59dbd9604e5@bmw-carit.de \
--to=daniel.wagner@bmw-carit.de \
--cc=C.Emde@osadl.org \
--cc=arnd@arndb.de \
--cc=binoy.jayan@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).