From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>,
LKML <linux-kernel@vger.kernel.org>,
Henry Sun <henrysun@google.com>,
Bob Moragues <moragues@chromium.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: arm: qcom: Document additional sku6 for sc7180 pazquel
Date: Wed, 20 Jul 2022 18:46:30 +0200 [thread overview]
Message-ID: <e0f6eede-9f6d-48d2-3a0a-e294cbe55eca@linaro.org> (raw)
In-Reply-To: <CAD=FV=WP22g2ZhyeGeYJcGtQTBeKjinxQRCXicHxeVh-ziC8iA@mail.gmail.com>
On 20/07/2022 17:07, Doug Anderson wrote:
> Hi,
>
> On Wed, Jul 20, 2022 at 12:46 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 20/07/2022 09:38, Yunlong Jia wrote:
>>> The difference between sku6 and sku4 is that there is no esim
>>>
>>> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
>>> ---
>>>
>>> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> index 4dd18fbf20b6..aebeefdab27f 100644
>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> @@ -410,6 +410,7 @@ properties:
>>> - description: Google Pazquel with LTE and Parade (newest rev)
>>> items:
>>> - const: google,pazquel-sku4
>>> + - const: google,pazquel-sku6
>>
>> This looks wrong, did you test it?
>
> Why do you think it's wrong? This patch is adding a second compatible
> string to an existing dts.
Because it was sent after a patch adding sku6+sku4+sc7180, but the order
here is different.
However for some reason it was not part of a patchset which makes it
total mess and even less possible to understand.
> The only difference between SKU4 and SKU6
> is that one of them has the eSIM component stuffed and the other one
> doesn't. This need not be represented in the dts since the eSIM is
> automatically detected, but it was still stuffed as a SKU strapping so
> the factory could tell whether the missing eSIM was an error or
> intentional.
>
> This is just like the SKU0 vs. SKU2 difference.
>
> Other than the fact that this should be together in one series with
> the dts patch:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
I don't agree. With last DTS patch this is a wrong binding (or wrong
DTS) therefore I must NAK it.
Please do not upstream stuff in some different way, like sending
bindings and DTS separate.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-07-20 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 7:38 [PATCH] dt-bindings: arm: qcom: Document additional sku6 for sc7180 pazquel Yunlong Jia
2022-07-20 7:46 ` Krzysztof Kozlowski
2022-07-20 15:07 ` Doug Anderson
2022-07-20 16:46 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0f6eede-9f6d-48d2-3a0a-e294cbe55eca@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=henrysun@google.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moragues@chromium.org \
--cc=robh+dt@kernel.org \
--cc=yunlong.jia@ecs.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).