From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Kalle Valo <kvalo@codeaurora.org>, Kees Cook <keescook@chromium.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Jes Sorensen <Jes.Sorensen@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang
Date: Thu, 11 Mar 2021 01:16:17 -0600 [thread overview]
Message-ID: <e10b2a6a-d91a-9783-ddbe-ea2c10a1539a@embeddedor.com> (raw)
In-Reply-To: <878s6uyy30.fsf@codeaurora.org>
On 3/11/21 01:00, Kalle Valo wrote:
> Kees Cook <keescook@chromium.org> writes:
>
>> On Fri, Mar 05, 2021 at 03:40:33PM +0200, Kalle Valo wrote:
>>> "Gustavo A. R. Silva" <gustavoars@kernel.org> writes:
>>>
>>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix
>>>> multiple warnings by replacing /* fall through */ comments with
>>>> the new pseudo-keyword macro fallthrough; instead of letting the
>>>> code fall through to the next case.
>>>>
>>>> Notice that Clang doesn't recognize /* fall through */ comments as
>>>> implicit fall-through markings.
>>>>
>>>> Link: https://github.com/KSPP/linux/issues/115
>>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>>>
>>> It's not cool that you ignore the comments you got in [1], then after a
>>> while mark the patch as "RESEND" and not even include a changelog why it
>>> was resent.
>>>
>>> [1] https://patchwork.kernel.org/project/linux-wireless/patch/d522f387b2d0dde774785c7169c1f25aa529989d.1605896060.git.gustavoars@kernel.org/
>>
>> Hm, this conversation looks like a miscommunication, mainly? I see
>> Gustavo, as requested by many others[1], replacing the fallthrough
>> comments with the "fallthrough" statement. (This is more than just a
>> "Clang doesn't parse comments" issue.)
>
> v1 was clearly rejected by Jes, so sending a new version without any
> changelog or comments is not the way to go. The changelog shoud at least
> have had "v1 was rejected but I'm resending this again because <insert
> reason here>" or something like that to make it clear what's happening.
Why the fact that I replied to that original thread with the message
below is being ignored?
"Just notice that the idea behind this and the following patch is exactly
the same:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=3f95e92c8a8516b745594049dfccc8c5f8895eea
I could resend this same patch with a different changelog text, but I
don't think such a thing is necessary. However, if people prefer that
approach, just let me know and I can do it.
Thanks
--
Gustavo"
Why no one replied to what I was proposing at the time?
It seems to me that the person that was ignored was actually me, and not the
other way around. :/
--
Gustavo
>
>> This could be a tree-wide patch and not bother you, but Greg KH has
>> generally advised us to send these changes broken out. Anyway, this
>> change still needs to land, so what would be the preferred path? I think
>> Gustavo could just carry it for Linus to merge without bothering you if
>> that'd be preferred?
>
> I agree with Greg. Please don't do cleanups like this via another tree
> as that just creates more work due to conflicts between the trees, which
> is a lot more annoying to deal with than applying few patches. But when
> submitting patches please follow the rules, don't cut corners.
>
> Jes, I don't like 'fallthrough' either and prefer the original comment,
> but the ship has sailed on this one. Maybe we should just take it?
>
next prev parent reply other threads:[~2021-03-11 7:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 9:48 [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-03-05 13:40 ` Kalle Valo
2021-03-05 16:49 ` Gustavo A. R. Silva
2021-03-10 19:14 ` Kees Cook
2021-03-10 19:31 ` Jes Sorensen
2021-03-10 19:45 ` Kees Cook
2021-03-10 19:51 ` Jes Sorensen
2021-03-10 20:59 ` Kees Cook
2021-04-17 18:29 ` Jes Sorensen
2021-04-17 19:24 ` Gustavo A. R. Silva
2021-04-19 11:58 ` Jes Sorensen
2021-03-11 7:00 ` Kalle Valo
2021-03-11 7:16 ` Gustavo A. R. Silva [this message]
2021-04-17 17:52 ` Kalle Valo
[not found] ` <20210417175201.2D5A7C433F1@smtp.codeaurora.org>
2021-04-17 18:30 ` Jes Sorensen
2021-04-18 0:09 ` Joe Perches
2021-04-19 11:56 ` Jes Sorensen
[not found] ` <20210417175201.280F9C4338A@smtp.codeaurora.org>
2021-04-19 22:58 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e10b2a6a-d91a-9783-ddbe-ea2c10a1539a@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=Jes.Sorensen@gmail.com \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).