From: Daniel Baluta <daniel.baluta@nxp.com>
To: Anson Huang <Anson.Huang@nxp.com>,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, rui.zhang@intel.com,
daniel.lezcano@linaro.org, amit.kucheria@verdurent.com,
robh+dt@kernel.org, leonard.crestez@nxp.com,
linux@rempel-privat.de, peng.fan@nxp.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-pm@vger.kernel.org0001-dt-bindings-firmware-imx-Move-system-control-into-dt.patch
Cc: Linux-imx@nxp.com
Subject: Re: [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h
Date: Thu, 23 Apr 2020 17:19:17 +0300 [thread overview]
Message-ID: <e13f4012-a022-be83-54e3-5eb010006961@nxp.com> (raw)
In-Reply-To: <1587650382-18586-2-git-send-email-Anson.Huang@nxp.com>
On 4/23/20 4:59 PM, Anson Huang wrote:
> The linux/firmware/imx/types.h has been merged into
> dt-bindings/firmware/imx/rsrc.h, change the includes
> in imx_sc_thermal.c driver accordingly.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/thermal/imx_sc_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index b2b68c9..b01d28e 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -3,9 +3,9 @@
> * Copyright 2018-2020 NXP.
> */
>
> +#include <dt-bindings/firmware/imx/rsrc.h>
> #include <linux/err.h>
> #include <linux/firmware/imx/sci.h>
> -#include <linux/firmware/imx/types.h>
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
You should do the operation of removing the header file and updating the
*.c files in one single patch.
Otherwise, we will break bisection. There will be states of the linux
kernel tree that do not compile.
next prev parent reply other threads:[~2020-04-23 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 13:59 [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h Anson Huang
2020-04-23 13:59 ` [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h Anson Huang
2020-04-23 14:19 ` Daniel Baluta [this message]
2020-04-23 15:13 ` [PATCH 2/3] firmware: imx: Remove unused include of linux/firmware/imx/types.h Aisheng Dong
2020-04-23 14:00 [PATCH 1/3] dt-bindings: firmware: imx: Move system control into dt-binding headfile Anson Huang
2020-04-23 14:00 ` [PATCH 3/3] thermal: imx_sc: Include rsrc.h instead of types.h Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e13f4012-a022-be83-54e3-5eb010006961@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org0001-dt-bindings-firmware-imx-Move-system-control-into-dt.patch \
--cc=linux@rempel-privat.de \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).