From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753509AbdHKOoZ (ORCPT ); Fri, 11 Aug 2017 10:44:25 -0400 Received: from esa1.dell-outbound.iphmx.com ([68.232.153.90]:57093 "EHLO esa1.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752883AbdHKOoX (ORCPT ); Fri, 11 Aug 2017 10:44:23 -0400 From: X-LoopCount0: from 10.175.216.251 X-IronPort-AV: E=Sophos;i="5.41,358,1498539600"; d="scan'208";a="135677211" X-DLP: DLP_GlobalPCIDSS To: , , CC: , , , Subject: RE: [PATCH v2 2/2] ACPI / Sleep: Check low power idle constraints for debug only Thread-Topic: [PATCH v2 2/2] ACPI / Sleep: Check low power idle constraints for debug only Thread-Index: AQHTEJd5DYozQpt5QUOCUpRzgsJy7qJ+J2owgABiYwCAALPugA== Date: Fri, 11 Aug 2017 14:43:25 +0000 Message-ID: References: <1502232075-23832-1-git-send-email-srinivas.pandruvada@linux.intel.com> <1502232075-23832-3-git-send-email-srinivas.pandruvada@linux.intel.com> <146e121b5db84fb8a8aa692cee01cb7b@ausx13mpc120.AMER.DELL.COM> <1502405652.20268.20.camel@linux.intel.com> In-Reply-To: <1502405652.20268.20.camel@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7BEiWZ5012143 > -----Original Message----- > From: Srinivas Pandruvada [mailto:srinivas.pandruvada@linux.intel.com] > Sent: Thursday, August 10, 2017 5:54 PM > To: Limonciello, Mario ; rjw@rjwysocki.net; > lenb@kernel.org > Cc: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > acpi@vger.kernel.org; lukas@wunner.de > Subject: Re: [PATCH v2 2/2] ACPI / Sleep: Check low power idle constraints for > debug only > > On Thu, 2017-08-10 at 22:07 +0000, Mario.Limonciello@dell.com wrote: > > > > > > > > > [...] > > > > + > > > + ret = acpi_device_get_power(adev, &state); > > > + if (!ret) > > > + pr_debug("LPI: %s required min power state > > > %d, current > > > power state %d, real power state %d\n", > > > +  lpi_constraints_table[i].name, > > > +  lpi_constraints_table[i].min_dsta > > > te, > > > +  adev->power.state, state); > > Isn't this superfluous to be showing the state returned from > > acpi_device_get_power and > > also probing directly at the state? You can't just rely on the > > information you got > > back from apci_device_get_power? > They can be different as one is real power state and the other is what > was set. > For example on Dell 9365 it shows > > [ 1924.393653] LPI: \_SB.PCI0.XHC required min power state 3, current > power state 3, real power state 255 > Isn't 255 ACPI_STATE_UNKNOWN? That makes it seem like it is a logic problem in acpi_device_get_power (or somewhere down the chain) doesn't it? > > > > > > > > + > > > + if (adev->flags.power_manageable && adev- > > > >power.state < > > > + lpi_constraints_table[i].m > > > in_dstate) > > > + pr_info("LPI: Constraint [%s] not > > > matched\n", > > > +  lpi_constraints_table[i].name); > > Similarly here, can't you just compare against &state instead? > > > The problem then the check will fail for XHCI on Dell 9365. So not > using "state". > > Thanks, > Srinivas > > > > > > + } > > > +} > > > + > > >  static void acpi_sleep_run_lps0_dsm(unsigned int func) > > >  { > > >   union acpi_object *out_obj; > > > @@ -729,6 +886,9 @@ static int lps0_device_attach(struct > > > acpi_device *adev, > > >     "_DSM function 0 evaluation > > > failed\n"); > > >   } > > >   ACPI_FREE(out_obj); > > > + > > > + lpi_device_get_constraints(); > > > + > > >   return 0; > > >  } > > > > > > @@ -773,6 +933,8 @@ static void acpi_freeze_wake(void) > > >    */ > > >   if (acpi_sci_irq_valid() && > > >       !irqd_is_wakeup_armed(irq_get_irq_data(acpi_sci_irq))) > > > { > > > + if (pm_debug_messages_enabled()) > > > + lpi_check_constraints(); > > >   pm_system_cancel_wakeup(); > > >   s2idle_wakeup = true; > > >   } > > > -- > > > 2.7.5