From: Joe Lawrence <joe.lawrence@redhat.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Jessica Yu <jeyu@redhat.com>, Jiri Kosina <jikos@kernel.org>,
Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v6] livepatch: introduce shadow variable API
Date: Tue, 12 Sep 2017 18:11:00 -0400 [thread overview]
Message-ID: <e161216a-e82b-f89a-b177-3ab103993733@redhat.com> (raw)
In-Reply-To: <20170912162034.lmpkjjefg3ft4m7r@treble>
On 09/12/2017 12:20 PM, Josh Poimboeuf wrote:
> On Thu, Aug 31, 2017 at 04:37:41PM -0400, Joe Lawrence wrote:
>> +void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
>> + size_t size, gfp_t gfp_flags, bool warn_on_exist)
>> +{
>> + struct klp_shadow *new_shadow;
>> + void *shadow_data;
>> + unsigned long flags;
>> +
>> + /* Check if the shadow variable if <obj, id> already exists */
>
> Grammar fix: either
>
> s/if the shadow variable//
>
> or
>
> s/if <obj, id>//
>
> Otherwise:
>
> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
If this is the only outstanding nit, can this be fixed up on merge or
does it need a new patch spin?
Thanks,
-- Joe
next prev parent reply other threads:[~2017-09-12 22:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 20:37 [PATCH v6] Livepatch shadow variables Joe Lawrence
2017-08-31 20:37 ` [PATCH v6] livepatch: introduce shadow variable API Joe Lawrence
2017-09-12 16:20 ` Josh Poimboeuf
2017-09-12 22:11 ` Joe Lawrence [this message]
2017-09-13 13:45 ` Jiri Kosina
2017-09-13 12:00 ` Miroslav Benes
2017-09-14 21:08 ` [PATCH v6] Livepatch shadow variables Jiri Kosina
2017-09-25 15:45 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e161216a-e82b-f89a-b177-3ab103993733@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).