From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A9D2C10F13 for ; Fri, 12 Apr 2019 02:08:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF1B020869 for ; Fri, 12 Apr 2019 02:08:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbfDLCIU (ORCPT ); Thu, 11 Apr 2019 22:08:20 -0400 Received: from gate.crashing.org ([63.228.1.57]:52087 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726640AbfDLCIU (ORCPT ); Thu, 11 Apr 2019 22:08:20 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x3C27AcS014202; Thu, 11 Apr 2019 21:07:11 -0500 Message-ID: Subject: Re: [PATCH v2 01/21] docs/memory-barriers.txt: Rewrite "KERNEL I/O BARRIER EFFECTS" section From: Benjamin Herrenschmidt To: Linus Torvalds Cc: Will Deacon , linux-arch , Linux List Kernel Mailing , "Paul E. McKenney" , Michael Ellerman , Arnd Bergmann , Peter Zijlstra , Andrea Parri , Palmer Dabbelt , Daniel Lustig , David Howells , Alan Stern , "Maciej W. Rozycki" , Paul Burton , Ingo Molnar , Yoshinori Sato , Rich Felker , Tony Luck , Mikulas Patocka , Akira Yokosawa , Luis Chamberlain , Nicholas Piggin Date: Fri, 12 Apr 2019 12:07:09 +1000 In-Reply-To: References: <20190405135936.7266-1-will.deacon@arm.com> <20190405135936.7266-2-will.deacon@arm.com> <080d1ec73e3e29d6ffeeeb50b39b613da28afb37.camel@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-04-11 at 15:34 -0700, Linus Torvalds wrote: > On Thu, Apr 11, 2019 at 3:13 PM Benjamin Herrenschmidt > wrote: > > > > Minor nit... I would have said "All readX() and writeX() accesses > > _from > > the same CPU_ to the same peripheral... and then s/the CPU/this > > CPU. > > Maybe talk about "same thread" rather than "same cpu", with the > understanding that scheduling/preemption has to include the > appropriate cross-CPU IO barrier? Works for me, but why not spell all this out in the document ? We know, but others might not. Cheers, Ben.