From: Markus Elfring <Markus.Elfring@web.de>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
linux-amlogic@lists.infradead.org, linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Corentin Labbe <clabbe@baylibre.com>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH] crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe()
Date: Fri, 3 Apr 2020 10:45:21 +0200 [thread overview]
Message-ID: <e1916128-6554-ea57-49ef-e4ad7b0d7229@web.de> (raw)
> In this place,
I suggest to omit such a wording from the change description.
> when something goes wrong, platform_get_irq() will
> print an error message,
This information is helpful here.
> so in order to avoid the situation of repeat output,
Possible adjustments:
* Separate sentences
* “repeated output”
> we should remove dev_err here.
Thus remove a redundant function call.
How do you think about to change any more source files in a systematic way?
Regards,
Markus
next reply other threads:[~2020-04-03 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:45 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-03 1:57 [PATCH] crypto:amlogic - Delete duplicate dev_err in meson_crypto_probe() Tang Bin
2020-04-03 7:44 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1916128-6554-ea57-49ef-e4ad7b0d7229@web.de \
--to=markus.elfring@web.de \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).