From: Linyu Yuan <quic_linyyuan@quicinc.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Tom Zanussi <zanussi@kernel.org>, Ingo Molnar <mingo@redhat.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/3] tracing: eprobe: remove duplicate is_good_name() operation
Date: Mon, 20 Jun 2022 09:03:31 +0800 [thread overview]
Message-ID: <e1a484a5-b14e-ab6d-09e7-645b1e740beb@quicinc.com> (raw)
In-Reply-To: <20220617214942.1dbfb55b@gandalf.local.home>
hi tom,
On 6/18/2022 9:49 AM, Steven Rostedt wrote:
> On Tue, 14 Jun 2022 09:04:56 +0800
> Linyu Yuan <quic_linyyuan@quicinc.com> wrote:
>
>> traceprobe_parse_event_name() already validate group and event name,
>> there is no need to call is_good_name() after it.
>>
>> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>> Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
>> ---
>> v2: drop v1 change as it is NACK.
>> add it to remove duplicate is_good_name().
>> v3: move it as first patch.
>> v4: no change
>> v5: add Acked-by tag
>>
>> kernel/trace/trace_eprobe.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/kernel/trace/trace_eprobe.c b/kernel/trace/trace_eprobe.c
>> index 7d44785..17d64e3 100644
>> --- a/kernel/trace/trace_eprobe.c
>> +++ b/kernel/trace/trace_eprobe.c
>> @@ -878,16 +878,12 @@ static int __trace_eprobe_create(int argc, const char *argv[])
>> sanitize_event_name(buf1);
>> event = buf1;
>> }
>> - if (!is_good_name(event) || !is_good_name(group))
>> - goto parse_error;
>>
> Tom replied that the above may be an issue. You ignored his response.
>
> -- Steve
>
i reply his mail in V4
https://lore.kernel.org/lkml/d14f0409-351f-873e-b7ca-82ff444bf809@quicinc.com/,
form my view, i think it is safe, in !event case Tom mentioned, we will
generate event from SYSTEM.EVENT
which is verified by traceprobe_parse_event_name().
Tom, could you review it again ?
>> sys_event = argv[1];
>> ret = traceprobe_parse_event_name(&sys_event, &sys_name, buf2,
>> sys_event - argv[1]);
>> if (ret || !sys_name)
>> goto parse_error;
>> - if (!is_good_name(sys_event) || !is_good_name(sys_name))
>> - goto parse_error;
>>
>> mutex_lock(&event_mutex);
>> event_call = find_and_get_event(sys_name, sys_event);
next prev parent reply other threads:[~2022-06-20 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 1:04 [PATCH v5 0/3] tracing/probes: allow no event name input when create group Linyu Yuan
2022-06-14 1:04 ` [PATCH v5 1/3] tracing: eprobe: remove duplicate is_good_name() operation Linyu Yuan
2022-06-18 1:49 ` Steven Rostedt
2022-06-20 1:03 ` Linyu Yuan [this message]
2022-06-14 1:04 ` [PATCH v5 2/3] tracing: auto generate event name when create a group of events Linyu Yuan
2022-06-14 1:04 ` [PATCH v5 3/3] selftests/ftrace: add test case for GRP/ only input Linyu Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1a484a5-b14e-ab6d-09e7-645b1e740beb@quicinc.com \
--to=quic_linyyuan@quicinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).