From: Sylwester Nawrocki <snawrocki@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: samsung: allow compile testing of Exynos, S3C64xx and S5Pv210
Date: Mon, 23 Nov 2020 11:10:44 +0100 [thread overview]
Message-ID: <e1d25f8d-5d33-3dc9-1af4-4afca7a8a967@kernel.org> (raw)
In-Reply-To: <20201122113425.GA6633@kozik-lap>
On 11/22/20 12:34, Krzysztof Kozlowski wrote:
> On Fri, Nov 20, 2020 at 05:36:35PM +0100, Sylwester Nawrocki wrote:
>> On 11/19/20 17:45, Krzysztof Kozlowski wrote:
>>> So far all Exynos, S3C64xx and S5Pv210 clock units were selected by
>>> respective SOC/ARCH Kconfig option. On a kernel built for selected
>>> SoCs, this allowed to build only limited set of matching clock drivers.
>>> However compile testing was not possible in such case as Makefile object
>>> depent on SOC/ARCH option.
>>
>> "objects depend" or "object depends" ?
>
> "object depends"
>
>>> Add separate Kconfig options for each of them to be able to compile
>>> test.
>>>
>>> Signed-off-by: Krzysztof Kozlowski<krzk@kernel.org>
>>
>> The patch look good to me, thanks.
>> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>>
>> I guess it's best now to merge it through your tree as it depends on
>> patches already sent to arm-soc? Next time it might be better to use
>> immutable branches right away to keep the clk changes in the clk
>> maintainer's tree.
>
> At that time I had only one clk patch so I did not put it on separate
> branch.
>
> Anyway, this does not depend on the clkout patches and only minor patch
> adjustement is needed. Cherry-pick can solve it (you would need to apply
> on next/master and then cherry pick) or I can resend you one rebased on
> linus/master.
>
> There should be no conflicts when merging later into next or linus.
>
> I propose you should take it via clk tree.
Indeed, the conflict is minimal, I should have checked with git cherry-pick
once I found a branch where the patch applied cleanly. I have corrected
the typo an applied, thank you!
--
Regards,
Sylwester
prev parent reply other threads:[~2020-11-23 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201119164614epcas1p23b1a2b17bf89f6396b7979fff623bdee@epcas1p2.samsung.com>
2020-11-19 16:45 ` [PATCH] clk: samsung: allow compile testing of Exynos, S3C64xx and S5Pv210 Krzysztof Kozlowski
2020-11-20 10:39 ` Chanwoo Choi
2020-11-20 16:36 ` Sylwester Nawrocki
2020-11-22 11:34 ` Krzysztof Kozlowski
2020-11-23 10:10 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1d25f8d-5d33-3dc9-1af4-4afca7a8a967@kernel.org \
--to=snawrocki@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).