From: Max Staudt <mstaudt@suse.de>
To: Randy Dunlap <rdunlap@infradead.org>,
b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org
Cc: tiwai@suse.com, oneukum@suse.com, msrb@suse.com,
sndirsch@suse.com, michal@markovi.net,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 10/14] bootsplash: Add animation support
Date: Wed, 25 Oct 2017 19:23:09 +0200 [thread overview]
Message-ID: <e1dd42e7-d6f8-a0a8-409d-fab95b24279c@suse.de> (raw)
In-Reply-To: <2b47c2af-1ddd-a526-601e-1781bef65232@infradead.org>
On 10/25/2017 07:20 PM, Randy Dunlap wrote:
> On 10/25/17 05:45, Max Staudt wrote:
>> @@ -117,17 +128,45 @@ static bool is_fb_compatible(struct fb_info *info)
>> */
>> void bootsplash_render_full(struct fb_info *info)
>> {
>> + bool is_update = false;
>> +
>> mutex_lock(&splash_global.data_lock);
>>
>> - if (!is_fb_compatible(info))
>> - goto out;
>> + /* If we've painted on this FB recently, we don't have to do
>> + * the sanity checks and background drawing again.
>> + */
>
> multi-line comment style needs to be corrected in multiple places (in
> several of the patches).
Sorry, I'll fix that. Thanks.
Max
next prev parent reply other threads:[~2017-10-25 17:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 12:45 [RFC 00/14] Kernel based bootsplash Max Staudt
2017-10-25 12:45 ` [RFC 01/14] bootsplash: Initial implementation showing black screen Max Staudt
2017-10-25 17:26 ` Randy Dunlap
2017-10-25 12:45 ` [RFC 02/14] bootsplash: Add platform device Max Staudt
2017-10-25 12:45 ` [RFC 03/14] bootsplash: Flush framebuffer after drawing Max Staudt
2017-10-25 12:45 ` [RFC 04/14] bootsplash: Redraw on suspend/hibernate Max Staudt
2017-10-25 12:45 ` [RFC 05/14] bootsplash: Disable splash on oops Max Staudt
2017-10-25 12:45 ` [RFC 06/14] bootsplash: Disable on SysRq SAK Max Staudt
2017-10-25 12:45 ` [RFC 07/14] bootsplash: Add VT keyboard hook Max Staudt
2017-10-25 12:45 ` [RFC 08/14] bootsplash: Add file reading and picture rendering Max Staudt
2017-10-25 17:32 ` Randy Dunlap
2017-10-25 20:27 ` Takashi Iwai
2017-10-27 11:21 ` Max Staudt
2017-10-25 12:45 ` [RFC 09/14] bootsplash: Add corner positioning Max Staudt
2017-10-25 12:45 ` [RFC 10/14] bootsplash: Add animation support Max Staudt
2017-10-25 17:20 ` Randy Dunlap
2017-10-25 17:23 ` Max Staudt [this message]
2017-10-25 12:45 ` [RFC 11/14] bootsplash: Redraw fully on console_unblank Max Staudt
2017-10-25 12:46 ` [RFC 12/14] bootsplash: Add sysfs ABI documentation Max Staudt
2017-10-25 12:46 ` [RFC 13/14] bootsplash: Add main documentation Max Staudt
2017-10-25 17:43 ` Randy Dunlap
2017-10-27 11:19 ` Max Staudt
2017-10-27 16:48 ` Randy Dunlap
2017-10-25 12:46 ` [RFC 14/14] bootsplash: Update MAINTAINERS Max Staudt
2017-11-09 11:56 ` [RFC 00/14] Kernel based bootsplash Pavel Machek
2017-11-09 12:36 ` Oliver Neukum
2017-11-09 18:45 ` Pavel Machek
2017-11-10 16:53 ` Takashi Iwai
2017-11-09 12:42 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1dd42e7-d6f8-a0a8-409d-fab95b24279c@suse.de \
--to=mstaudt@suse.de \
--cc=b.zolnierkie@samsung.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal@markovi.net \
--cc=msrb@suse.com \
--cc=oneukum@suse.com \
--cc=rdunlap@infradead.org \
--cc=sndirsch@suse.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).