From: Randy Dunlap <rdunlap@infradead.org>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Jonathan Corbet <corbet@lwn.net>,
Andrew Murray <amurray@mpc-data.co.uk>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] doc: convert printk-formats.txt to rst
Date: Wed, 6 Dec 2017 16:39:58 -0800 [thread overview]
Message-ID: <e21397c5-8d97-3cb8-0e67-c91de352b078@infradead.org> (raw)
In-Reply-To: <20171206211651.GD11835@eros>
On 12/06/2017 01:16 PM, Tobin C. Harding wrote:
> On Wed, Dec 06, 2017 at 10:18:49AM -0800, Randy Dunlap wrote:
>
> Thanks for your comments Randy.
>
>>> Documentation/index.rst | 10 +
>>> .../{printk-formats.txt => printk-formats.rst} | 295 ++++++++++++---------
>>> lib/vsprintf.c | 160 +++++------
>>> 3 files changed, 235 insertions(+), 230 deletions(-)
>>> rename Documentation/{printk-formats.txt => printk-formats.rst} (61%)
>>
>>> diff --git a/Documentation/printk-formats.txt b/Documentation/printk-formats.rst
>>> similarity index 61%
>>> rename from Documentation/printk-formats.txt
>>> rename to Documentation/printk-formats.rst
>>> index aa0a776c817a..51449d213748 100644
>>> --- a/Documentation/printk-formats.txt
>>> +++ b/Documentation/printk-formats.rst
>>> @@ -194,8 +233,8 @@ printing SSIDs.
>>>
>>> If field width is omitted the 1 byte only will be escaped.
>>
>> then
>> I think...
>
> Ha ha, I was borderline with this change when doing this patch. It may
> not appear so but I did try to do the minimal amount of changes while
> improving correctness. I appreciate your comments since hopefully I can
> better make these judgment calls next time.
I wasn't so sure about that attempt (at minimal changes). :)
> Will change as suggested.
>>> Where no additional specifiers are used the default big endian
>>> -order with lower case hex characters will be printed.
>>> +order with lower case hex digits will be printed.
>>
>> digits could imply base 10. but no big deal.
>
> Are you sure about this? I was under the impression that when
> representing a number the character set used are refereed to as 'digits'
> irrespective of base.
>
> hexadecimal digit
> octal digit
> digit (assumed base 10)
>
> Open to correction though.
Like I said, I don't care strongly about this. (I'm easy.)
but hex notation (like you said later) sounds good.
--
~Randy
next prev parent reply other threads:[~2017-12-07 0:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 1:45 [PATCH] doc: convert printk-formats.txt to rst Tobin C. Harding
2017-12-06 7:11 ` Markus Heiser
2017-12-06 7:35 ` Joe Perches
2017-12-06 17:55 ` Randy Dunlap
2017-12-06 18:18 ` Randy Dunlap
2017-12-06 21:16 ` Tobin C. Harding
2017-12-07 0:39 ` Randy Dunlap [this message]
2017-12-07 5:25 ` Tobin C. Harding
2017-12-06 22:11 ` Tobin C. Harding
2017-12-06 18:23 ` Jonathan Corbet
2017-12-06 21:30 ` Tobin C. Harding
2017-12-07 22:50 ` Kees Cook
2017-12-07 23:01 ` Jonathan Corbet
2017-12-07 23:50 ` Tobin C. Harding
2017-12-07 23:44 ` Tobin C. Harding
2017-12-08 0:19 ` Kees Cook
2017-12-08 0:46 ` Tobin C. Harding
2017-12-08 21:06 ` Kees Cook
2017-12-08 21:22 ` Joe Perches
2017-12-09 1:27 ` Tobin C. Harding
2017-12-09 2:18 ` Joe Perches
2017-12-09 6:33 ` Tobin C. Harding
2017-12-11 18:40 ` Laura Abbott
2017-12-09 11:48 ` Dan Carpenter
2017-12-11 0:51 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e21397c5-8d97-3cb8-0e67-c91de352b078@infradead.org \
--to=rdunlap@infradead.org \
--cc=amurray@mpc-data.co.uk \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).