From: David Laight <David.Laight@ACULAB.COM>
To: 'Alex Elder' <elder@linaro.org>,
'Manikishan Ghantasala' <manikishanghantasala@gmail.com>,
Alex Elder <elder@ieee.org>
Cc: Alex Elder <elder@kernel.org>,
"greybus-dev@lists.linaro.org" <greybus-dev@lists.linaro.org>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
Johan Hovold <johan@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [greybus-dev] [PATCH] staging: greybus: fixed the coding style, labels should not be indented.
Date: Thu, 3 Jun 2021 21:48:13 +0000 [thread overview]
Message-ID: <e23879ae78404be2b707b550b3029e43@AcuMS.aculab.com> (raw)
In-Reply-To: <e1c36fb4-ab72-0cce-f6fe-3f04125dae28@linaro.org>
From: Alex Elder
> Sent: 03 June 2021 22:46
>
> On 6/3/21 4:22 PM, David Laight wrote:
...
> >>>> --- a/drivers/staging/greybus/gpio.c
> >>>> +++ b/drivers/staging/greybus/gpio.c
> >>>> @@ -20,9 +20,9 @@
> >>>> struct gb_gpio_line {
> >>>> /* The following has to be an array of line_max entries */
> >>>> /* --> make them just a flags field */
> >>>> - u8 active: 1,
> >>>> - direction: 1, /* 0 = output, 1 = input */
> >>>> - value: 1; /* 0 = low, 1 = high */
> >>>> + u8 active:1,
> >>>> + direction:1, /* 0 = output, 1 = input */
> >>>> + value:1; /* 0 = low, 1 = high */
> >
> > Why are you even using bitfields at all?
> > If you cared about the structure size you'd not have a byte-size pad here.
>
> Apparently I committed this, and it was part of the very first
> Greybus drivers...
>
> These would be better defined as Booleans; there are others in
> the same structure after all. That would have avoided the
> checkpatch problem in the first place.
Using 'u8' can be sensible.
Boolean will be 32bit.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-06-03 21:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 13:36 [PATCH] staging: greybus: fixed the coding style, labels should not be indented sh4nnu
2021-06-02 13:43 ` Alex Elder
2021-06-02 14:27 ` Manikishan Ghantasala
2021-06-02 14:37 ` Greg Kroah-Hartman
2021-06-02 14:39 ` Manikishan Ghantasala
2021-06-02 17:26 ` [PATCH] checkpatch: Improve the indented label test Joe Perches
2021-06-02 14:38 ` [PATCH] staging: greybus: fixed the coding style, labels should not be indented Alex Elder
2021-06-03 21:22 ` David Laight
2021-06-03 21:45 ` [greybus-dev] " Alex Elder
2021-06-03 21:48 ` David Laight [this message]
2021-06-03 21:55 ` Alex Elder
2021-06-04 8:13 ` David Laight
2021-06-04 8:26 ` Joe Perches
2021-06-04 8:33 ` David Laight
2021-06-04 12:34 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e23879ae78404be2b707b550b3029e43@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manikishanghantasala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).