From: James Tai <james.tai@realtek.com>
To: "Andreas Färber" <afaerber@suse.de>,
"linux-realtek-soc@lists.infradead.org"
<linux-realtek-soc@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [RFC 06/11] soc: realtek: chip: Detect RTD1296
Date: Thu, 2 Jan 2020 14:35:52 +0000 [thread overview]
Message-ID: <e23f24e7c018440bbf72317fbcc1b22f@realtek.com> (raw)
In-Reply-To: <20191103013645.9856-7-afaerber@suse.de>
> Detection logic from downstream drivers/soc/realtek/rtd129x/rtk_chip.c.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> drivers/soc/realtek/chip.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/realtek/chip.c b/drivers/soc/realtek/chip.c index
> 9d13422e9936..ba653c097644 100644
> --- a/drivers/soc/realtek/chip.c
> +++ b/drivers/soc/realtek/chip.c
> @@ -50,9 +50,25 @@ static const char *default_name(struct device *dev,
> const struct rtd_soc *s)
> return s->family;
> }
>
> +static const char *rtd1295_name(struct device *dev, const struct
> +rtd_soc *s) {
> + void __iomem *base;
> +
> + base = of_iomap(dev->of_node, 1);
> + if (base) {
> + u32 chipinfo1 = readl_relaxed(base);
> + iounmap(base);
> + if (chipinfo1 & BIT(11)) {
> + return "RTD1296";
> + }
> + }
> +
> + return "RTD1295";
> +}
> +
> static const struct rtd_soc rtd_soc_families[] = {
> { 0x00006329, "RTD1195", default_name, rtd1195_revisions, "Phoenix" },
> - { 0x00006421, "RTD1295", default_name, rtd1295_revisions, "Kylin" },
> + { 0x00006421, "RTD1295", rtd1295_name, rtd1295_revisions, "Kylin" },
> };
>
> static const struct rtd_soc *rtd_soc_by_chip_id(u32 chip_id)
> --
> 2.16.4
>
Acked-by: James Tai <james.tai@realtek.com>
next prev parent reply other threads:[~2020-01-02 14:36 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 1:36 [RFC 00/11] ARM: Realtek RTD1195/RTD1295 SoC info Andreas Färber
2019-11-03 1:36 ` [RFC 01/11] dt-bindings: soc: Add Realtek RTD1195 chip info binding Andreas Färber
2019-11-06 4:41 ` Rob Herring
2019-11-03 1:36 ` [RFC 02/11] soc: Add Realtek chip info driver for RTD1195 and RTD1295 Andreas Färber
2019-11-03 1:45 ` Andreas Färber
2019-11-11 4:56 ` [PATCH] base: soc: Export soc_device_to_device() helper Andreas Färber
2019-11-11 5:27 ` Greg Kroah-Hartman
2019-11-11 5:42 ` Andreas Färber
2019-11-11 6:40 ` Greg Kroah-Hartman
2019-11-11 20:10 ` Andreas Färber
2019-11-12 0:29 ` Andreas Färber
2019-11-12 5:23 ` Greg Kroah-Hartman
2019-11-12 7:29 ` Uwe Kleine-König
2019-11-12 10:47 ` Sense of soc bus? (was: [PATCH] base: soc: Export soc_device_to_device() helper) Andreas Färber
2019-11-14 22:09 ` Rob Herring
2019-11-15 11:15 ` Andreas Färber
2019-11-15 11:49 ` Andreas Färber
2019-11-15 8:52 ` Neil Armstrong
2019-11-15 8:58 ` Geert Uytterhoeven
2019-11-15 12:00 ` Andreas Färber
2019-11-15 12:34 ` Geert Uytterhoeven
2019-11-18 15:55 ` Tony Lindgren
2019-11-12 10:48 ` [PATCH] base: soc: Export soc_device_to_device() helper Lee Jones
2020-01-02 14:29 ` [RFC 02/11] soc: Add Realtek chip info driver for RTD1195 and RTD1295 James Tai
2020-01-02 14:39 ` Andreas Färber
2020-01-02 15:02 ` James Tai
2020-01-03 5:07 ` Stanley Chang[昌育德]
2019-11-03 1:36 ` [RFC 03/11] arm64: dts: realtek: rtd129x: Add chip info node Andreas Färber
2020-01-02 14:32 ` James Tai
2020-01-03 5:07 ` Stanley Chang[昌育德]
2020-01-02 14:33 ` James Tai
2020-01-02 14:34 ` James Tai
2019-11-03 1:36 ` [RFC 04/11] ARM: dts: rtd1195: " Andreas Färber
2019-11-03 1:36 ` [RFC 05/11] dt-bindings: soc: realtek: rtd1195-chip: Extend reg property Andreas Färber
2019-11-06 4:46 ` Rob Herring
2019-11-06 8:42 ` Andreas Färber
2019-11-03 1:36 ` [RFC 06/11] soc: realtek: chip: Detect RTD1296 Andreas Färber
2020-01-02 14:35 ` James Tai [this message]
2019-11-03 1:36 ` [RFC 07/11] arm64: dts: realtek: rtd129x: Extend chip-info reg with CHIP_INFO1 Andreas Färber
2019-11-03 1:36 ` [RFC 08/11] soc: realtek: chip: Detect RTD1293 Andreas Färber
2019-11-03 1:36 ` [RFC 09/11] dt-bindings: soc: realtek: rtd1195-chip: Extend reg node again Andreas Färber
2019-11-03 1:36 ` [RFC 10/11] soc: realtek: chip: Detect RTD1294 Andreas Färber
2019-11-03 1:36 ` [RFC 11/11] arm64: dts: realtek: rtd129x: Extend chip-info reg with efuse Andreas Färber
2019-11-07 7:16 ` [RFC 00/11] ARM: Realtek RTD1195/RTD1295 SoC info Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e23f24e7c018440bbf72317fbcc1b22f@realtek.com \
--to=james.tai@realtek.com \
--cc=afaerber@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).