From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Gwendal Grignou <gwendal@chromium.org>,
Yicheng Li <yichengli@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
"kernel@collabora.com" <kernel@collabora.com>
Subject: Re: [PATCH] mfd: cros_ec: Update cros_ec_commands.h
Date: Mon, 22 Jul 2019 16:15:49 +0200 [thread overview]
Message-ID: <e241dc48-5cb0-3b60-9b84-cad8e80eb617@collabora.com> (raw)
In-Reply-To: <CAPUE2uvnPfA8y1bqppC3-vZyRKRwdF4evGY8X4c-xP=YZi4HRw@mail.gmail.com>
Hi Lee,
On 11/7/19 19:17, Gwendal Grignou wrote:
> Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>
> Note there is a patch series that move cros_ec_commands.h from
> nclude/linux/mfd/ to include/linux/platform_data.
>
I just sent a new version of the patches mentioned above now that rc1 is out [1]
As Gwendal said this patch will conflict with them, so we have two options.
1. If Lee picks that patch I can rebase again my series on top of it.
2. If not, we can wait for Lee reviewing my patch series and then I don't mind
to rebase that patch on top of my series and carry the patch through
chrome-platform. Anyway I'll need an immutable branch from Lee.
> On Mon, Jul 8, 2019 at 11:16 AM Yicheng Li <yichengli@chromium.org> wrote:
>>
>> Update cros_ec_commands.h to match the fingerprint MCU section in
>> the current ec_commands.h
>>
>> Signed-off-by: Yicheng Li <yichengli@chromium.org>
For the first case:
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks,
~ Enric
[1] https://lkml.org/lkml/2019/7/22/497
>> ---
>>
>> include/linux/mfd/cros_ec_commands.h | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
>> index 7ccb8757b79d..98415686cbfa 100644
>> --- a/include/linux/mfd/cros_ec_commands.h
>> +++ b/include/linux/mfd/cros_ec_commands.h
>> @@ -5513,6 +5513,18 @@ struct ec_params_fp_seed {
>> uint8_t seed[FP_CONTEXT_TPM_BYTES];
>> } __ec_align4;
>>
>> +#define EC_CMD_FP_ENC_STATUS 0x0409
>> +
>> +/* FP TPM seed has been set or not */
>> +#define FP_ENC_STATUS_SEED_SET BIT(0)
>> +
>> +struct ec_response_fp_encryption_status {
>> + /* Used bits in encryption engine status */
>> + uint32_t valid_flags;
>> + /* Encryption engine status */
>> + uint32_t status;
>> +} __ec_align4;
>> +
>> /*****************************************************************************/
>> /* Touchpad MCU commands: range 0x0500-0x05FF */
>>
>> --
>> 2.20.1
>>
next prev parent reply other threads:[~2019-07-22 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 18:15 [PATCH] mfd: cros_ec: Update cros_ec_commands.h Yicheng Li
2019-07-11 17:17 ` Gwendal Grignou
2019-07-22 14:15 ` Enric Balletbo i Serra [this message]
2019-08-12 7:28 ` Lee Jones
2019-08-21 17:27 ` Enric Balletbo i Serra
2019-08-12 7:27 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e241dc48-5cb0-3b60-9b84-cad8e80eb617@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yichengli@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).