From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 607E8C6778C for ; Fri, 29 Jun 2018 20:09:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1796C27C40 for ; Fri, 29 Jun 2018 20:09:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lechnology.com header.i=@lechnology.com header.b="VMLlxlJ6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1796C27C40 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lechnology.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935326AbeF2UJn (ORCPT ); Fri, 29 Jun 2018 16:09:43 -0400 Received: from vern.gendns.com ([206.190.152.46]:57886 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932925AbeF2UJl (ORCPT ); Fri, 29 Jun 2018 16:09:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=y2SUyEJVRjh04xZtjr2XSGglxrg9+DSKDc7BQex3wS8=; b=VMLlxlJ6YxaIFecVQ0xL1FY4xp krQyCO15Cj0nFSIxZtyk4guBFvgirMo7OncJQrDLUd2u0DdpxJOcZ30O0GhaJar/Z06L9dFFPxvYJ JvmdRxsLSomXM/8iNTZ9cYZIZurdylqpkCNnUXxV7pO3L5F0Fz0/FHm0vIt5u82TNdgaxHY7b9WH+ GaFZ857Qcqe1yxJerW7kyJSdoIQFLoi2NEb+o6+Ch7Exwq12VW19OFiMFDnAEKHUnsYc/yXh1cSxj s2XyNcfY+K231c6QVVD4chTLlJqYucmdSz4Rlj4ozJFGo9eUUqQHtfSWizpCpAl1VOmf6aMNGNrJo T5pAH1Ig==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:42618 helo=[192.168.0.134]) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1fYzi4-002wLz-MZ; Fri, 29 Jun 2018 16:09:36 -0400 Subject: Re: [PATCH v4 08/18] net: davinci_emac: potentially get the MAC address from MTD To: Bartosz Golaszewski , Sekhar Nori , Kevin Hilman , Russell King , Grygorii Strashko , "David S . Miller" , Srinivas Kandagatla , Lukas Wunner , Rob Herring , Florian Fainelli , Dan Carpenter , Ivan Khoronzhuk , Greg Kroah-Hartman , Andrew Lunn , Jonathan Corbet Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, netdev@vger.kernel.org, Bartosz Golaszewski References: <20180629094039.7543-1-brgl@bgdev.pl> <20180629094039.7543-9-brgl@bgdev.pl> From: David Lechner Message-ID: Date: Fri, 29 Jun 2018 15:09:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180629094039.7543-9-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/29/2018 04:40 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > On da850-evm board we can read the MAC address from MTD. It's currently > done in the relevant board file, but we want to get rid of all the MAC > reading callbacks from the board file (SPI and NAND). Move the reading > of the MAC address from SPI to the emac driver's probe function. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/net/ethernet/ti/davinci_emac.c | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c > index a1a6445b5a7e..48e6a7755811 100644 > --- a/drivers/net/ethernet/ti/davinci_emac.c > +++ b/drivers/net/ethernet/ti/davinci_emac.c > @@ -67,7 +67,7 @@ > #include > #include > #include > - > +#include > #include > #include > > @@ -1783,7 +1783,10 @@ static int davinci_emac_probe(struct platform_device *pdev) > struct cpdma_params dma_params; > struct clk *emac_clk; > unsigned long emac_bus_frequency; > - > +#ifdef CONFIG_MTD > + size_t mac_addr_len; > + struct mtd_info *mtd; > +#endif /* CONFIG_MTD */ > > /* obtain emac clock from kernel */ > emac_clk = devm_clk_get(&pdev->dev, NULL); > @@ -1815,6 +1818,19 @@ static int davinci_emac_probe(struct platform_device *pdev) > goto err_free_netdev; > } > > +#ifdef CONFIG_MTD What about the case when MTD is compiled as a module? > + mtd = get_mtd_device_nm("MAC-Address"); What about the case when PTR_ERR(mtd) == -EPROBE_DEFER? > + if (!IS_ERR(mtd)) { > + rc = mtd_read(mtd, 0, ETH_ALEN, > + &mac_addr_len, priv->mac_addr); > + if (rc == 0) > + dev_info(&pdev->dev, > + "Read MAC addr from SPI Flash: %pM\n", > + priv->mac_addr); > + put_mtd_device(mtd); > + } > +#endif /* CONFIG_MTD */ > + > /* MAC addr and PHY mask , RMII enable info from platform_data */ > memcpy(priv->mac_addr, pdata->mac_addr, ETH_ALEN); > priv->phy_id = pdata->phy_id; >