From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>,
airlied@linux.ie, thierry.reding@gmail.com, daniel@ffwll.ch
Cc: Rob Clark <robdclark@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
MSM <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] drm/panel: truly: Add additional delay after pulling down reset gpio
Date: Wed, 29 May 2019 11:27:10 +0530 [thread overview]
Message-ID: <e260c253-66af-cb09-f685-8bf62f0d5547@codeaurora.org> (raw)
In-Reply-To: <7dfcf294-6ab1-c1ce-352d-dfdeec4347af@free.fr>
On 5/28/2019 2:13 PM, Marc Gonzalez wrote:
> On 27/05/2019 12:26, Vivek Gautam wrote:
>
>> MTP SDM845 panel seems to need additional delay to bring panel
>> to a workable state. Running modetest without this change displays
>> blurry artifacts.
>>
>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>> ---
>> drivers/gpu/drm/panel/panel-truly-nt35597.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c
>> index fc2a66c53db4..aa7153fd3be4 100644
>> --- a/drivers/gpu/drm/panel/panel-truly-nt35597.c
>> +++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c
>> @@ -280,6 +280,7 @@ static int truly_35597_power_on(struct truly_nt35597 *ctx)
>> gpiod_set_value(ctx->reset_gpio, 1);
>> usleep_range(10000, 20000);
>> gpiod_set_value(ctx->reset_gpio, 0);
>> + usleep_range(10000, 20000);
> I'm not sure usleep_range() makes sense with these values.
>
> AFAIU, usleep_range() is typically used for sub-jiffy sleeps, and is based
> on HRT to generate an interrupt.
>
> Once we get into jiffy granularity, it seems to me msleep() is good enough.
> IIUC, it would piggy-back on the jiffy timer interrupt.
>
> In short, why not just use msleep(10); ?
I am just maintaining the symmetry across older code.
Thanks
Vivek
>
> Regards.
next prev parent reply other threads:[~2019-05-29 5:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 10:26 [PATCH 1/1] drm/panel: truly: Add additional delay after pulling down reset gpio Vivek Gautam
2019-05-28 8:43 ` Marc Gonzalez
2019-05-29 5:57 ` Vivek Gautam [this message]
2019-06-05 8:22 ` Sam Ravnborg
2019-06-06 11:18 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e260c253-66af-cb09-f685-8bf62f0d5547@codeaurora.org \
--to=vivek.gautam@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=robdclark@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).