From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753504AbdDDLFG (ORCPT ); Tue, 4 Apr 2017 07:05:06 -0400 Received: from foss.arm.com ([217.140.101.70]:42590 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753260AbdDDLEr (ORCPT ); Tue, 4 Apr 2017 07:04:47 -0400 Subject: Re: [PATCH V10 05/12] ACPI/IORT: Add function to check SMMUs drivers presence To: Sricharan R , will.deacon@arm.com, joro@8bytes.org, lorenzo.pieralisi@arm.com, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, m.szyprowski@samsung.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, tn@semihalf.com, hanjun.guo@linaro.org, okaya@codeaurora.org, robh+dt@kernel.org, frowand.list@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org, catalin.marinas@arm.com, arnd@arndb.de, linux-arch@vger.kernel.org, gregkh@linuxfoundation.org References: <1489086061-9356-1-git-send-email-sricharan@codeaurora.org> <1491301105-5274-1-git-send-email-sricharan@codeaurora.org> <1491301105-5274-6-git-send-email-sricharan@codeaurora.org> From: Robin Murphy Message-ID: Date: Tue, 4 Apr 2017 12:04:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1491301105-5274-6-git-send-email-sricharan@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/17 11:18, Sricharan R wrote: > From: Lorenzo Pieralisi > > The IOMMU probe deferral implementation requires a mechanism to detect > if drivers for SMMU components are built-in in the kernel to detect > whether IOMMU configuration for a given device should be deferred (ie > SMMU drivers present but still not probed) or not (drivers not present). > > Add a simple function to IORT to detect if SMMU drivers for SMMU > components managed by IORT are built-in in the kernel. Ah, if only DT could be this neat and tidy :D Reviewed-by: Robin Murphy > Tested-by: Hanjun Guo > Signed-off-by: Lorenzo Pieralisi > Cc: Robin Murphy > Cc: Sricharan R > --- > drivers/acpi/arm64/iort.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index 4a5bb96..3dd9ec3 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -523,6 +523,19 @@ static int arm_smmu_iort_xlate(struct device *dev, u32 streamid, > return ret; > } > > +static inline bool iort_iommu_driver_enabled(u8 type) > +{ > + switch (type) { > + case ACPI_IORT_NODE_SMMU_V3: > + return IS_BUILTIN(CONFIG_ARM_SMMU_V3); > + case ACPI_IORT_NODE_SMMU: > + return IS_BUILTIN(CONFIG_ARM_SMMU); > + default: > + pr_warn("IORT node type %u does not describe an SMMU\n", type); > + return false; > + } > +} > + > static const struct iommu_ops *iort_iommu_xlate(struct device *dev, > struct acpi_iort_node *node, > u32 streamid) >