From: Frank Rowand <frowand.list@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Bill Mills <bill.mills@linaro.org>,
anmar.oueja@linaro.org
Subject: Re: [PATCH V2 1/2] scripts: dtc: Add fdtoverlay.c and fdtdump.c to DTC_SOURCE
Date: Tue, 19 Jan 2021 10:31:08 -0600 [thread overview]
Message-ID: <e272ec7f-fa6e-9c35-142c-9f2dff0115ce@gmail.com> (raw)
In-Reply-To: <eb85b5ba-e2c5-7601-6934-089b5b1370d2@gmail.com>
On 1/19/21 10:21 AM, Frank Rowand wrote:
> On 1/6/21 11:15 PM, Viresh Kumar wrote:
>> We will start building overlays for platforms soon in the kernel and
>> would need these tools going forward. Lets start fetching them.
>>
>> Note that a copy of fdtdump.c was already copied back in the year 2012,
>> but was never updated or built for some reason.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> V2: Separate out this change from Makefile one.
>>
>> This needs to be followed by invocation of the ./update-dtc-source.sh
>> script so the relevant files can be copied before the Makefile is
>> updated in the next patch.
>>
>> scripts/dtc/update-dtc-source.sh | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/scripts/dtc/update-dtc-source.sh b/scripts/dtc/update-dtc-source.sh
>> index bc704e2a6a4a..9bc4afb71415 100755
>> --- a/scripts/dtc/update-dtc-source.sh
>> +++ b/scripts/dtc/update-dtc-source.sh
>> @@ -31,9 +31,9 @@ set -ev
>> DTC_UPSTREAM_PATH=`pwd`/../dtc
>> DTC_LINUX_PATH=`pwd`/scripts/dtc
>>
>> -DTC_SOURCE="checks.c data.c dtc.c dtc.h flattree.c fstree.c livetree.c srcpos.c \
>> - srcpos.h treesource.c util.c util.h version_gen.h yamltree.c \
>> - dtc-lexer.l dtc-parser.y"
>> +DTC_SOURCE="checks.c data.c dtc.c dtc.h fdtdump.c fdtoverlay.c flattree.c \
>> + fstree.c livetree.c srcpos.c srcpos.h treesource.c util.c \
>> + util.h version_gen.h yamltree.c dtc-lexer.l dtc-parser.y"
>> LIBFDT_SOURCE="fdt.c fdt.h fdt_addresses.c fdt_empty_tree.c \
>> fdt_overlay.c fdt_ro.c fdt_rw.c fdt_strerror.c fdt_sw.c \
>> fdt_wip.c libfdt.h libfdt_env.h libfdt_internal.h"
>>
>
> DTC_SOURCE is for the dtc program. Please add a FDTOVERLAY_SOURCE and
> related use for the fdtoverlay program.
I see that this patch series is up to v4, so I commented in the wrong place.
I will repeat this comment in the v4 series.
-Frank
>
> -Frank
>
prev parent reply other threads:[~2021-01-19 18:27 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 5:15 [PATCH V2 1/2] scripts: dtc: Add fdtoverlay.c and fdtdump.c to DTC_SOURCE Viresh Kumar
2021-01-07 5:15 ` [PATCH V2 2/2] scripts: dtc: Build fdtoverlay and fdtdump tools Viresh Kumar
2021-01-07 5:45 ` Masahiro Yamada
2021-01-07 6:25 ` [PATCH V3 " Viresh Kumar
2021-01-12 0:44 ` Frank Rowand
2021-01-12 5:08 ` Viresh Kumar
2021-01-12 18:34 ` Frank Rowand
2021-01-13 4:55 ` Viresh Kumar
2021-01-12 0:55 ` Frank Rowand
2021-01-12 4:48 ` Viresh Kumar
2021-01-19 16:28 ` [PATCH V2 " Frank Rowand
2021-01-19 16:34 ` Frank Rowand
2021-01-08 8:41 ` [PATCH] of: unittest: Statically apply overlays using fdtoverlay Viresh Kumar
2021-01-11 15:46 ` Rob Herring
2021-01-11 22:09 ` Frank Rowand
2021-01-14 5:03 ` Viresh Kumar
2021-01-14 15:01 ` Rob Herring
2021-01-15 5:44 ` Viresh Kumar
2021-01-18 3:54 ` Frank Rowand
2021-01-19 2:30 ` Frank Rowand
2021-01-18 6:30 ` David Gibson
2021-01-19 2:29 ` Frank Rowand
2021-01-11 22:06 ` Frank Rowand
2021-01-12 1:22 ` Bill Mills
2021-01-12 8:37 ` Viresh Kumar
2021-01-12 10:16 ` Bill Mills
2021-01-12 18:17 ` Frank Rowand
2021-01-12 14:04 ` Rob Herring
2021-01-12 19:06 ` Frank Rowand
2021-01-12 19:41 ` Rob Herring
2021-01-12 20:05 ` Frank Rowand
2021-01-12 20:46 ` Rob Herring
2021-01-13 2:20 ` Frank Rowand
2021-01-13 15:05 ` Rob Herring
2021-01-13 17:21 ` Frank Rowand
2021-01-14 5:00 ` Viresh Kumar
2021-01-19 2:25 ` Frank Rowand
2021-01-19 2:21 ` frowand.list
2021-01-19 8:05 ` Viresh Kumar
2021-01-19 15:44 ` Frank Rowand
2021-01-20 5:06 ` Viresh Kumar
2021-01-20 6:20 ` Viresh Kumar
2021-01-21 5:00 ` Frank Rowand
2021-01-21 5:09 ` Viresh Kumar
2021-01-21 6:41 ` David Gibson
2021-01-11 22:13 ` [PATCH V2 1/2] scripts: dtc: Add fdtoverlay.c and fdtdump.c to DTC_SOURCE Frank Rowand
2021-01-12 4:45 ` Viresh Kumar
2021-01-19 16:21 ` Frank Rowand
2021-01-19 16:31 ` Frank Rowand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e272ec7f-fa6e-9c35-142c-9f2dff0115ce@gmail.com \
--to=frowand.list@gmail.com \
--cc=anmar.oueja@linaro.org \
--cc=bill.mills@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).