From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2208C433DB for ; Fri, 12 Mar 2021 08:57:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A332064FE0 for ; Fri, 12 Mar 2021 08:57:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232317AbhCLIxl (ORCPT ); Fri, 12 Mar 2021 03:53:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20189 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232323AbhCLIx1 (ORCPT ); Fri, 12 Mar 2021 03:53:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615539206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aRwrXGJxMq+pYmK820MBZhCTt+haXKGrGPdMmRxI0UE=; b=hDHb9rqSWSxZzb0vhKTzMjXVdJ84VfxdX9gTb4gSUmGIfEimvBaFqr8nLc16D73u8tiCJs D8GuLOiUdRp0RCn1OIEo7zBYh8EQ8oAEhjyKUohwixUeTyP5v77v1UtKvFZkG6OW2Gmn2w O15q4yjVB2jKu4h4lN1uSOGWaWxFgmA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-88-QlZlJlPZOFyd5hptCQo_cQ-1; Fri, 12 Mar 2021 03:53:24 -0500 X-MC-Unique: QlZlJlPZOFyd5hptCQo_cQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8B4BB100C663; Fri, 12 Mar 2021 08:53:22 +0000 (UTC) Received: from [10.36.114.197] (ovpn-114-197.ams2.redhat.com [10.36.114.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id 85B4059466; Fri, 12 Mar 2021 08:53:10 +0000 (UTC) Subject: Re: [RFC 0/2] virtio-pmem: Asynchronous flush To: Dan Williams , Pankaj Gupta Cc: Pankaj Gupta , Linux Kernel Mailing List , linux-nvdimm , Vishal L Verma , Dave Jiang , "Michael S. Tsirkin" , jmoyer References: <20200420131947.41991-1-pankaj.gupta.linux@gmail.com> <7e55abc4-5c91-efb8-1b32-87570dde62cc@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Fri, 12 Mar 2021 09:53:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.03.21 07:02, Dan Williams wrote: > On Thu, Mar 11, 2021 at 8:21 PM Pankaj Gupta > wrote: >> >> Hi David, >> >>>> Jeff reported preflush order issue with the existing implementation >>>> of virtio pmem preflush. Dan suggested[1] to implement asynchronous flush >>>> for virtio pmem using work queue as done in md/RAID. This patch series >>>> intends to solve the preflush ordering issue and also makes the flush >>>> asynchronous from the submitting thread POV. >>>> >>>> Submitting this patch series for feeback and is in WIP. I have >>>> done basic testing and currently doing more testing. >>>> >>>> Pankaj Gupta (2): >>>> pmem: make nvdimm_flush asynchronous >>>> virtio_pmem: Async virtio-pmem flush >>>> >>>> drivers/nvdimm/nd_virtio.c | 66 ++++++++++++++++++++++++++---------- >>>> drivers/nvdimm/pmem.c | 15 ++++---- >>>> drivers/nvdimm/region_devs.c | 3 +- >>>> drivers/nvdimm/virtio_pmem.c | 9 +++++ >>>> drivers/nvdimm/virtio_pmem.h | 12 +++++++ >>>> 5 files changed, 78 insertions(+), 27 deletions(-) >>>> >>>> [1] https://marc.info/?l=linux-kernel&m=157446316409937&w=2 >>>> >>> >>> Just wondering, was there any follow up of this or are we still waiting >>> for feedback? :) >> >> Thank you for bringing this up. >> >> My apologies I could not followup on this. I have another version in my local >> tree but could not post it as I was not sure if I solved the problem >> correctly. I will >> clean it up and post for feedback as soon as I can. >> >> P.S: Due to serious personal/family health issues I am not able to >> devote much time >> on this with other professional commitments. I feel bad that I have >> this unfinished task. >> Just in last one year things have not been stable for me & my family >> and still not getting :( > > No worries Pankaj. Take care of yourself and your family. The > community can handle this for you. I'm open to coaching somebody > through what's involved to get this fix landed. Absolutely, no need to worry for now - take care of yourself and your loved ones! I was merely stumbling over this series while cleaning up my inbox, wondering if this is still stuck waiting for review/feedback. No need to rush anything or be stressed. In case I have time to look into this in the future, I'd coordinate in this thread (especially, asking for feedback again so I know where this series stands)! -- Thanks, David / dhildenb