From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE32C433EF for ; Wed, 9 Mar 2022 17:05:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236866AbiCIRGU (ORCPT ); Wed, 9 Mar 2022 12:06:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237570AbiCIRDE (ORCPT ); Wed, 9 Mar 2022 12:03:04 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F15F01B2AFB for ; Wed, 9 Mar 2022 08:51:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646844675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ciXf/kDeXmAL/6RIvTYI6KZ9lH0wgG0xeQwUhPXRPo=; b=Fr8PVEWzW23g589L41311HRt+hUngvzSxPNGaHcwQ5okgisvfHclXg7yG9lXaY+mjmTLZ0 bV77WQDF7E6gvs9GtaFBlCxht1s6I9DrMbb5dpuOum34uSWC2Q2hwH142tV/gKse8zuamJ 25fcuB818slZk9whDmtlikE/i0DLhF8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-FaGyAfbkPYijqRtMS18osg-1; Wed, 09 Mar 2022 11:51:14 -0500 X-MC-Unique: FaGyAfbkPYijqRtMS18osg-1 Received: by mail-wm1-f71.google.com with SMTP id k41-20020a05600c1ca900b00389a2b983efso1024357wms.4 for ; Wed, 09 Mar 2022 08:51:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0ciXf/kDeXmAL/6RIvTYI6KZ9lH0wgG0xeQwUhPXRPo=; b=rakEOW7KmQNvPyoxpYvgfuC/uFttfE29bnjzzMS0Dor/1VCUozdTa5guGHuLO46qLv /P528C7bxv9VcinefN0HXQ4oLcntykUMADTuG/FZzyAlEUnR79mwdHP6doTTgPJ2ngES CTjwy8QcZiFmVcRDuyNJOYM1hOe5RgfvL08WMgWejMLcVJob9ZtzZPwrkXMZN94Kc2gq Pz1Ya4DPiZY3CajfIC0Zl9cEAlCcxOC+RYqPQffySNPU1Ev08fNy9bnh5eN1w05deBmt cSlcY+sNa3t91bUeAPiSRV40jIRKRefWIUdZD3Hz3iGnUM2DhYuPglYxNI/EeU+dDiu8 mqbA== X-Gm-Message-State: AOAM533H8eblABXOGMCHYR2N193GWOC6HxUK55/fcvs+DUH6JzkGP360 Wjiaj2s0xr598aBUWOTOQtWGWq90IAEgE4N4RWv5H+yPMXOzQEwn6Gp3icH+/Vpn3BM02V6HsRQ uSoayg4b5PKjb0mmn5au0gsRZ X-Received: by 2002:a5d:638b:0:b0:203:787e:c17f with SMTP id p11-20020a5d638b000000b00203787ec17fmr424779wru.250.1646844672782; Wed, 09 Mar 2022 08:51:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwA+tfh26XUx+xmyq2nalkKMHvS2HVfplNvpDg8s9jAzd4fUnvCw/p4zg7E4ldS/LrrMS6S9w== X-Received: by 2002:a5d:638b:0:b0:203:787e:c17f with SMTP id p11-20020a5d638b000000b00203787ec17fmr424763wru.250.1646844672560; Wed, 09 Mar 2022 08:51:12 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id n15-20020a05600c4f8f00b003842f011bc5sm5877090wmq.2.2022.03.09.08.51.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Mar 2022 08:51:11 -0800 (PST) Message-ID: Date: Wed, 9 Mar 2022 17:51:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH MANUALSEL 5.10] KVM: x86: Yield to IPI target vCPU only if it is busy Content-Language: en-US To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Li RongQing , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, kvm@vger.kernel.org References: <20220309164645.138079-1-sashal@kernel.org> From: Paolo Bonzini In-Reply-To: <20220309164645.138079-1-sashal@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/9/22 17:46, Sasha Levin wrote: > From: Li RongQing > > [ Upstream commit 9ee83635d872812f3920209c606c6ea9e412ffcc ] > > When sending a call-function IPI-many to vCPUs, yield to the > IPI target vCPU which is marked as preempted. > > but when emulating HLT, an idling vCPU will be voluntarily > scheduled out and mark as preempted from the guest kernel > perspective. yielding to idle vCPU is pointless and increase > unnecessary vmexit, maybe miss the true preempted vCPU > > so yield to IPI target vCPU only if vCPU is busy and preempted > > Signed-off-by: Li RongQing > Message-Id: <1644380201-29423-1-git-send-email-lirongqing@baidu.com> > Signed-off-by: Paolo Bonzini > Signed-off-by: Sasha Levin > --- > arch/x86/kernel/kvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > index 7462b79c39de..8fe6eb5bed3f 100644 > --- a/arch/x86/kernel/kvm.c > +++ b/arch/x86/kernel/kvm.c > @@ -590,7 +590,7 @@ static void kvm_smp_send_call_func_ipi(const struct cpumask *mask) > > /* Make sure other vCPUs get a chance to run if they need to. */ > for_each_cpu(cpu, mask) { > - if (vcpu_is_preempted(cpu)) { > + if (!idle_cpu(cpu) && vcpu_is_preempted(cpu)) { > kvm_hypercall1(KVM_HC_SCHED_YIELD, per_cpu(x86_cpu_to_apicid, cpu)); > break; > } NACK