From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FFD1C433EF for ; Mon, 28 Mar 2022 13:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243359AbiC1NoG (ORCPT ); Mon, 28 Mar 2022 09:44:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243353AbiC1NoE (ORCPT ); Mon, 28 Mar 2022 09:44:04 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DDA44CD75 for ; Mon, 28 Mar 2022 06:42:22 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nYpdJ-0005kp-7J; Mon, 28 Mar 2022 15:42:09 +0200 Message-ID: Date: Mon, 28 Mar 2022 15:42:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: Ahmad Fatoum Subject: Re: [PATCH 3/5] arm64: dts: imx8mp: Enable HS400-ES To: Krzysztof Kozlowski , Adam Ford Cc: Krzysztof Kozlowski , linux-mmc , devicetree , Ulf Hansson , Fabio Estevam , Shawn Guo , Sascha Hauer , Adam Ford-BE , Haibo Chen , Linux Kernel Mailing List , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , arm-soc References: <20220327123835.28329-1-aford173@gmail.com> <20220327123835.28329-3-aford173@gmail.com> <74e74ea8-1554-bf08-b0ea-36e77259cb18@pengutronix.de> <5c24c12b-3a12-1e18-9f03-2c54cad30bf9@kernel.org> <5282b39b-85d5-81d6-10d5-a45c66d4d4e9@kernel.org> <010b3600-81dd-f5e3-2d57-8cab8efd58f0@pengutronix.de> <37da40fe-6e85-af40-756b-d022fe2559aa@kernel.org> Content-Language: en-US In-Reply-To: <37da40fe-6e85-af40-756b-d022fe2559aa@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.03.22 15:14, Krzysztof Kozlowski wrote: > On 28/03/2022 15:07, Ahmad Fatoum wrote: >> On 28.03.22 14:56, Krzysztof Kozlowski wrote: >>> You could also add two cases: >>> 1. three compatibles, deprecated: True, >>> 2. two compatibles, without imx7d. >>> >>> Existing DTS stays with three compatibles for two years and later gets >>> converted to two compatibles. New DTS should use two compatibles. >>> >>> It's quite a lot of churn, but would make in the long term bindings >>> correct and also not break other users/projects. >> >> I don't see why we need to deprecate the old binding. New SoCs >> can be imx8mm-usdhc compatible from the beginning and need not >> care about the old binding. Existing SoCs can just remain imx7d-usdhc >> compatible as they are now. >> >> I don't see what the deprecation accomplishes. > > It avoids to have too many entries of imx8mm (imx8mm alone, > imx8mm+imx7d, imx8xx+imx8mm+imx7d). I see. I assume use of deprecated binding will be reported on a dtbs_check? If so, the expectation is that downstream projects run dtbs_check on their imported Linux DT repository, see the deprecation warning and extend their drivers to comply with it. Some time later upstream will remove the deprecated binding and adjust the device trees. This works for me. Cheers, Ahmad > > Best regards, > Krzysztof > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |