From: Randy Dunlap <rdunlap@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: linux-next: Tree for Feb 7 (objtool warning)
Date: Mon, 10 Feb 2020 08:59:34 -0800 [thread overview]
Message-ID: <e2a5726f-1ddf-f95b-a3c3-b9d41a79579d@infradead.org> (raw)
In-Reply-To: <20200210102951.GD14879@hirez.programming.kicks-ass.net>
On 2/10/20 2:29 AM, Peter Zijlstra wrote:
> On Fri, Feb 07, 2020 at 08:17:25AM -0800, Randy Dunlap wrote:
>> on x86_64:
>>
>> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: i915_gem_execbuffer2_ioctl()+0x6c7: call to gen8_canonical_addr() with UACCESS enabled
>
>> CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>> CONFIG_64BIT=y
>
> That's just really sad, stupid compiler.
>
> Something like so I suppose...
Yes, that works. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> diff --git a/drivers/gpu/drm/i915/gt/intel_gpu_commands.h b/drivers/gpu/drm/i915/gt/intel_gpu_commands.h
> index 51b8718513bc..db6b75d4572f 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gpu_commands.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gpu_commands.h
> @@ -330,12 +330,12 @@
> * canonical form [63:48] == [47]."
> */
> #define GEN8_HIGH_ADDRESS_BIT 47
> -static inline u64 gen8_canonical_addr(u64 address)
> +static __always_inline u64 gen8_canonical_addr(u64 address)
> {
> return sign_extend64(address, GEN8_HIGH_ADDRESS_BIT);
> }
>
> -static inline u64 gen8_noncanonical_addr(u64 address)
> +static __always_inline u64 gen8_noncanonical_addr(u64 address)
> {
> return address & GENMASK_ULL(GEN8_HIGH_ADDRESS_BIT, 0);
> }
> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
> index 47f54b459c26..9acf654f0b19 100644
> --- a/include/linux/bitops.h
> +++ b/include/linux/bitops.h
> @@ -162,7 +162,7 @@ static inline __u8 ror8(__u8 word, unsigned int shift)
> *
> * This is safe to use for 16- and 8-bit types as well.
> */
> -static inline __s32 sign_extend32(__u32 value, int index)
> +static __always_inline __s32 sign_extend32(__u32 value, int index)
> {
> __u8 shift = 31 - index;
> return (__s32)(value << shift) >> shift;
> @@ -173,7 +173,7 @@ static inline __s32 sign_extend32(__u32 value, int index)
> * @value: value to sign extend
> * @index: 0 based bit index (0<=index<64) to sign bit
> */
> -static inline __s64 sign_extend64(__u64 value, int index)
> +static __always_inline __s64 sign_extend64(__u64 value, int index)
> {
> __u8 shift = 63 - index;
> return (__s64)(value << shift) >> shift;
>
--
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
next prev parent reply other threads:[~2020-02-10 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 0:59 linux-next: Tree for Feb 7 Stephen Rothwell
2020-02-07 16:17 ` linux-next: Tree for Feb 7 (objtool warning) Randy Dunlap
2020-02-10 10:29 ` Peter Zijlstra
2020-02-10 16:59 ` Randy Dunlap [this message]
2020-02-10 17:26 ` Josh Poimboeuf
2020-02-10 18:45 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2a5726f-1ddf-f95b-a3c3-b9d41a79579d@infradead.org \
--to=rdunlap@infradead.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).