From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
Jani Nikula <jani.nikula@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Jason Gunthorpe <jgg@ziepe.ca>, Peter Huewe <peterhuewe@gmx.de>,
Matthew Garrett <mjg59@google.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v2] tpm_tis: Disable interrupts if interrupt storm detected
Date: Fri, 04 Dec 2020 16:06:44 -0800 [thread overview]
Message-ID: <e2b07ef9132f150f6d8ee169e249b2ce33a0db10.camel@HansenPartnership.com> (raw)
In-Reply-To: <87czzpw88m.fsf@redhat.com>
On Fri, 2020-12-04 at 14:51 -0700, Jerry Snitselaar wrote:
> James Bottomley @ 2020-12-03 14:05 MST:
>
> > On Thu, 2020-12-03 at 13:14 -0700, Jerry Snitselaar wrote:
> > > Jerry Snitselaar @ 2020-12-02 23:11 MST:
> > [...]
> > > > The interrupt storm detection code works on the T490s. I'm not
> > > > sure what is going on with the L490. I will see if I can get
> > > > access to one.
> > > >
> > > > Jerry
> > >
> > > Lenovo verified that the L490 hangs.
> >
> > Just to confirm, that's this system:
> >
> > https://www.lenovo.com/us/en/laptops/thinkpad/thinkpad-l/ThinkPad-L490/p/22TP2TBL490
> >
> > We could ask if lenovo will give us one, but if not we could pull a
> > Jens. [the backstory is that when Jens was doing queueing in the
> > block layer, there were lots of SATA devices that didn't work quite
> > right but you couldn't tell unless you actually tried them
> > out. Getting manufacturers to send samples is rather arduous, so
> > he took to ordering them online, testing them out, and then
> > returning them for a full refund within the allowed window]
> >
> > It looks like Lenovo has a nice christmas returns policy:
> >
> > https://www.lenovo.com/us/en/shopping-faq/#returns
> >
> > James
>
> Yes, that is the one. I'm seeing if we have any located somewhere, or
> if Lenovo will loan me one.
OK, that would be best since it's your patch. We've got 12 days left
to get the free returns policy, so if you haven't managed to find one
by the end of next week, I'll order one and play with it ... you could
always put your manager's credit card down for one as well ...
especially as it should get refunded ...
> I think for the time being the patch that disabled interrupts for
> the T490s could be changed to it for the L490 instead. I'll post a v3
> of my current patchset. It would probably make sense for it to go in
> with your patches when they land.
Absolutely ... we can't turn interrupts on and then have a load of hung
laptops we already knew about ...
James
next prev parent reply other threads:[~2020-12-05 0:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 23:23 [PATCH] tpm_tis: Disable interrupts if interrupt storm detected Jerry Snitselaar
2020-12-01 2:58 ` [PATCH v2] " Jerry Snitselaar
2020-12-01 3:26 ` Jerry Snitselaar
2020-12-01 19:59 ` Jerry Snitselaar
2020-12-02 16:49 ` Jarkko Sakkinen
2020-12-03 0:02 ` Jerry Snitselaar
2020-12-03 6:11 ` Jerry Snitselaar
2020-12-03 20:14 ` Jerry Snitselaar
2020-12-03 21:05 ` James Bottomley
2020-12-04 21:51 ` Jerry Snitselaar
2020-12-05 0:06 ` James Bottomley [this message]
2020-12-04 1:59 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2b07ef9132f150f6d8ee169e249b2ce33a0db10.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=hdegoede@redhat.com \
--cc=jani.nikula@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@google.com \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).