From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965676AbcIERAR (ORCPT ); Mon, 5 Sep 2016 13:00:17 -0400 Received: from mout.web.de ([212.227.17.12]:60700 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965678AbcIEQ7Y (ORCPT ); Mon, 5 Sep 2016 12:59:24 -0400 Subject: [PATCH 12/21] ACPI-video: Delete unnecessary if statement in acpi_video_switch_brightness() To: linux-acpi@vger.kernel.org, Hans de Goede , Len Brown , "Rafael J. Wysocki" , Zhang Rui References: <566ABCD9.1060404@users.sourceforge.net> <897ebf36-2fe5-e109-adf6-b81b6e863d9a@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Mon, 5 Sep 2016 18:59:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <897ebf36-2fe5-e109-adf6-b81b6e863d9a@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:WhBrppycfh4eGHmQmo2RxLEpnhO6SMwH6m16jbB5LUe69il4yae 3EUKxsFmN6De6Q/7iTNExJ9iV/r0Q+BtZmeCHFFW4EnLTeWZqwt4uPo1WZJT2ttnjeinEq4 XxWy6hKMw0xSolowQEidAHv+qVJwmwToMH60zeeOznMj92fFG1KeL6W7DbS6RdmI2G1mK2M r/4wldiDAX88Q2oOMHX8Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:XdiZSVOWzV4=:7V2+8l68A5HcWizVsmSYNT ENdqnaLTQo6uRhBBDFtXVzaDnbcRrij6WBPAvCgLu/t5dmYa4D4B8nCaIW9dJJUOJ2r9HcDE/ wqADs/uKKEe7QqkAQ8lYYiug9ZiCNINJmER2cZz78RUftLHI0tztKwJ9enXDPaHebdbZs9WtQ 6jj8sYHEXnVXgOruXpWF0ouPnsthKAkwlqzGw9JsPWRAUGw9/3rPBHVuglZQyqK2bUKMLoq6G R0OMpQIH2aENsR3u0eSZ+h9q1uGM5MOC/lsezNynR4QCCijYmsulKwkCYFT1szCH0jdB3ZzcI XNdaSvRragWuxangKIjX2Ik8b52PtOGgW/VX4iItDiTibXvj7dewBBmaaCGKDQ3Fotzaskc68 DzEwOZ6uKQiLHDBDmJ2XZ4Xzp8vG+NpLReZpW/KYbNFl+3tpX/UJdPY/PJUfEFKLhZzqr1KLM 1kIQ2qPHfua09wPV+zfau4IP/ITVIBRYe3aaX4eLj1GuOcjJOMjZNv+Sb2H4zTHFtbsCzS9xx yPStUfSmtF9Am8iDmelTW/qEzRd+MfpkjzZbkCIlNdZdexykseO037NofP1lor232Uu3Ek0q3 /lDaL6T4gFBSsr3F8boWF9/N5SgIl9C3Eoe8BVToj4LdyF11LhRt0TZONPGL7ltCFuwtSgDGU inY9FzFR3B7DssqOSIKVsZUYr5mcCJAhkX/CwFh7vvrp+N/4KkK4oUBn3wHodjBLJ3ZVwD0CJ pJqPwQvhSlDVFjiw0yLyl5WLZWB5z721BJkQ5e2bMIR7uU6JncFniFsiOpqa4SxB5cazfR53I WYjOWGO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 5 Sep 2016 16:10:40 +0200 Move a function call into an else branch for successful function execution. Omit a duplicate check for the local variable "result" then at the end. Signed-off-by: Markus Elfring --- drivers/acpi/acpi_video.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index fe9b40e..0362a43 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -1372,14 +1372,12 @@ acpi_video_switch_brightness(struct work_struct *work) level_next = acpi_video_get_next_level(device, level_current, event); result = acpi_video_device_lcd_set_level(device, level_next); - - if (!result) - backlight_force_update(device->backlight, - BACKLIGHT_UPDATE_HOTKEY); - out: if (result) printk(KERN_ERR PREFIX "Failed to switch the brightness\n"); + else + backlight_force_update(device->backlight, + BACKLIGHT_UPDATE_HOTKEY); } int acpi_video_get_edid(struct acpi_device *device, int type, int device_id, -- 2.10.0