From: "Andrew F. Davis" <afd@ti.com>
To: Evgeniy Polyakov <zbr@ioremap.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] w1: Add subsystem kernel public interface
Date: Mon, 1 May 2017 12:36:26 -0500 [thread overview]
Message-ID: <e2cfddfe-f56b-1b83-eaa6-bb24067889b8@ti.com> (raw)
In-Reply-To: <5478321493483316@web21g.yandex.ru>
On 04/29/2017 11:28 AM, Evgeniy Polyakov wrote:
> Hi everyone
>
> 16.03.2017, 18:20, "Andrew F. Davis" <afd@ti.com>:
>> Like other subsystems we should be able to define slave devices outside
>> of the w1 directory. To do this we move public facing interface
>> definitions to include/linux/w1.h and rename the internal definition
>> file to w1_internal.h.
>>
>> As w1_family.h and w1_int.h contained almost entirely public
>> driver interface definitions we simply removed these files and
>> moved the remaining definitions into w1_internal.h.
>
> w1_int.h was a shortname for w1_internal.h actually
>
>> With this we can now start to move slave devices out of w1/slaves and
>> into the subsystem based on the function they implement, again like
>> other drivers.
>
> I'm not against this patch per-se, I especially like linux/w1 include instead of ../w1.h,
> quite curious why didn't I move include file into linux directory in the first place,
> but please elaborate why is this needed?
>
I'm moving the bq27xxx driver out of w1 and into power/supply where it
should be, see:
https://lkml.org/lkml/2017/3/16/688
> Also I do not agree with TI copyright in the new inclusion file which is merely a movement of the old file.
>
There is more going on that just moving the file, this was a lot of
re-work, also I kept your copyright, is it a problem to add another? If
so I'm fine with that too and can remove it.
Andrew
next prev parent reply other threads:[~2017-05-01 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 15:19 [PATCH 0/3] Add public w1 driver interface Andrew F. Davis
2017-03-16 15:19 ` [PATCH 1/3] w1: Use kernel common min() implementation Andrew F. Davis
2017-03-16 15:19 ` [PATCH 2/3] w1: Remove unneeded use of assert() and remove w1_log.h Andrew F. Davis
2017-03-16 15:19 ` [PATCH 3/3] w1: Add subsystem kernel public interface Andrew F. Davis
[not found] ` <5478321493483316@web21g.yandex.ru>
2017-05-01 17:36 ` Andrew F. Davis [this message]
2017-03-25 18:47 ` [PATCH 0/3] Add public w1 driver interface Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2cfddfe-f56b-1b83-eaa6-bb24067889b8@ti.com \
--to=afd@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).