linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Mark Harmstone <mark@harmstone.com>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Cc: "Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH v2 05/10] fs/ntfs3: Add attrib operations
Date: Fri, 28 Aug 2020 16:52:03 +0000	[thread overview]
Message-ID: <e2decd9632cd4d218fb83e96c0c37174@paragon-software.com> (raw)

From: Mark Harmstone <mark.harmstone@gmail.com> On Behalf Of Mark Harmstone
Sent: Monday, August 24, 2020 7:14 PM
> 
> Hi Konstantin,
> 
> I have an interest in this - I wrote the Btrfs driver for Windows, which also had to deal with the issue of how to map NTFS concept to
> Linux xattrs. Unless there's a good reason, I think it'd be in everyone's interests if we used the same conventions.
> 
> You have four(!) different ways of referring to the attributes value, which seems a bit excessive. I suggest you just use
> user.DOSATTRIB - this should be in the user namespace as users can set e.g. the hidden flag on files at will. This also matches what my
> driver does, and what Samba does.
> 

Hi Mark! Thanks for the feedback. It's reasonable concern, but the open 
question is how to access those NTFS attributes which extend the DOS 
attributes. user.DOSATTRIB may be good for FAT32 as DOS attributes are stored in 8bit.
However, this does not apply to NTFS (32bit attributes).

> I also think it's a mistake to only expose user.DOSATTRIB to Samba - there's patches in Wine staging which would also benefit from
> this.
> 

Agreed. Will fix this in v4. We think historically this came from wrong reading of
"This extended attribute is explicitly hidden from smbd clients requesting an EA list."

> Also, unless I'm missing something there's a bug in ntfs_setxattr - the user shouldn't be able to clear the FILE_ATTRIBUTE_DIRECTORY
> flag on directories nor set it on files.
> 

Thanks! Fixed in v3.

> Thanks
> 
> Mark
> 


             reply	other threads:[~2020-08-28 16:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 16:52 Konstantin Komarov [this message]
2020-08-29 12:53 ` [PATCH v2 05/10] fs/ntfs3: Add attrib operations Mark Harmstone
2020-09-04 12:52   ` Konstantin Komarov
  -- strict thread matches above, loose matches on Subject: below --
2020-08-21 16:25 Konstantin Komarov
2020-08-24 16:14 ` Mark Harmstone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2decd9632cd4d218fb83e96c0c37174@paragon-software.com \
    --to=almaz.alexandrovich@paragon-software.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@harmstone.com \
    --cc=pali@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).