From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E74ECAAA3 for ; Fri, 26 Aug 2022 11:32:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236397AbiHZLcx (ORCPT ); Fri, 26 Aug 2022 07:32:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245527AbiHZLcm (ORCPT ); Fri, 26 Aug 2022 07:32:42 -0400 Received: from mail-sz.amlogic.com (mail-sz.amlogic.com [211.162.65.117]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9CC1DB7F2; Fri, 26 Aug 2022 04:32:39 -0700 (PDT) Received: from [10.28.39.83] (10.28.39.83) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.6; Fri, 26 Aug 2022 19:32:37 +0800 From: Huqiang Qin Subject: Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h To: Krzysztof Kozlowski , , , , , , CC: , , , Message-ID: Date: Fri, 26 Aug 2022 19:32:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.28.39.83] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 2022/8/25 20:02, Krzysztof Kozlowski wrote: > Why? We can see what you did here, but commit msg should explain why you > do it... Sorry, I didn't describe this commit message clearly. In the future, meson-s4.dtsi will have some nodes that need to use the meson-s4-gpio.h file. e.g. (1) Bluetooth enable pin: bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>; (2) Audio mute pin: spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>; (3) ... So, this patch was born. Best regards, Huqiang