From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 036A4C4363C for ; Sun, 4 Oct 2020 20:55:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DE2C206DD for ; Sun, 4 Oct 2020 20:55:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UctFYXnX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726519AbgJDUzE (ORCPT ); Sun, 4 Oct 2020 16:55:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50756 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726313AbgJDUzE (ORCPT ); Sun, 4 Oct 2020 16:55:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601844903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mWH/ATVcRB7rwNAEkwbR+sPGrk7a5wftqQOirUz0nmI=; b=UctFYXnXRsA1Nk3OiJsnFE8ZY/Ev9LUO/yRKrjdJ6JoFI17LRPvT+Y6TsCvbX2SZEgwjBS L6us0cDDaMkGd2XxDV47ah8thWGOMbuQ5+2XkeGA2KcAQK+IFqWg/Y3SDpJomtZxun5mMO vhEwkIVmH7wzBai5XCHYaJerKMdh62s= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-YVUaJKJ0Mr6qCfQQZNhpmw-1; Sun, 04 Oct 2020 16:55:01 -0400 X-MC-Unique: YVUaJKJ0Mr6qCfQQZNhpmw-1 Received: by mail-qk1-f199.google.com with SMTP id m23so5231451qkh.10 for ; Sun, 04 Oct 2020 13:55:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=mWH/ATVcRB7rwNAEkwbR+sPGrk7a5wftqQOirUz0nmI=; b=qAbS3/g9V8Z29hN+8JksdG/6u6qXzuqPt201e1NR2S7XfUVeZsIYzKHrc2mzATBlzR zCrZ/3NfMy/FOtmXJwNiGekBTBgi7i7CiaKJg97XxikhfyFuUt9JUa3wccUyPcVyXeNO yIfdsuvTXZAVT86S3CS7D3jB5hifEXDx7G01z5GUNWB6scX7zN7HWsYKJSbDFmXQOask 2K216Kf/J+2xOwXy8vnJYbVIxYZ9EwJDwc4u5t/StH3qTOBHQxQMyRGK1QJ/2K55lV/C iDllFaOSrVrifG/DWnS9FRVcyRrF00EuHab4alnPSDdGEhxvNKm3mQT3d1doAJTPdlyd kzig== X-Gm-Message-State: AOAM532AAa49QRiJ6ozwZFYY79Aj0ge15eVMzJ0OossrI7skvFexcrb5 XrrL7VnrOE0tmX93rkNk8T1LneMYqLMB1FefHxDlUutTwc56ZlLyNBQiSmEaV3oSCBj4wLuwkRl 4akrGGogCU0tG6jcRy+pslxr0 X-Received: by 2002:a05:6214:a52:: with SMTP id ee18mr6575003qvb.39.1601844901113; Sun, 04 Oct 2020 13:55:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7ljUKirqqONC/NLVsmD8e12Wp8sO1Z5hEP2gFusS5Ws9vES2qIHHnxW6he4aW9gqe3Vqekw== X-Received: by 2002:a05:6214:a52:: with SMTP id ee18mr6574990qvb.39.1601844900893; Sun, 04 Oct 2020 13:55:00 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id f3sm1232955qtp.57.2020.10.04.13.54.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Oct 2020 13:55:00 -0700 (PDT) Subject: Re: [PATCH v2 2/7] fpga: sec-mgr: enable secure updates To: Russ Weight , mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com, matthew.gerlach@intel.com References: <20201002223701.1317-1-russell.h.weight@intel.com> <20201002223701.1317-3-russell.h.weight@intel.com> From: Tom Rix Message-ID: Date: Sun, 4 Oct 2020 13:54:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201002223701.1317-3-russell.h.weight@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/2/20 3:36 PM, Russ Weight wrote: > Extend the FPGA Intel Security Manager class driver to > include an update/filename sysfs node that can be used > to initiate a security update. The filename of a secure > update file (BMC image, FPGA image, Root Entry Hash image, > or Code Signing Key cancellation image) can be written to > this sysfs entry to cause a secure update to occur. > > The write of the filename will return immediately, and the > update will begin in the context of a kernel worker thread. > This tool utilizes the request_firmware framework, which > requires that the image file reside under /lib/firmware. > > Signed-off-by: Russ Weight > --- > v2: > - Bumped documentation date and version > - Removed explicit value assignments in enums > - Other minor code cleanup per review comments > --- > .../ABI/testing/sysfs-class-ifpga-sec-mgr | 13 ++ > drivers/fpga/ifpga-sec-mgr.c | 157 ++++++++++++++++++ > include/linux/fpga/ifpga-sec-mgr.h | 49 ++++++ > 3 files changed, 219 insertions(+) This was 05/12 in the old patchset. Looks good. Reviewed-by: Tom Rix