From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B3DC433E0 for ; Sat, 13 Mar 2021 09:33:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0877F64F11 for ; Sat, 13 Mar 2021 09:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230349AbhCMJdP (ORCPT ); Sat, 13 Mar 2021 04:33:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38498 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232974AbhCMJdN (ORCPT ); Sat, 13 Mar 2021 04:33:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615627992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Tdndx9aurgi/5sVvvOA/y0ZDMqTihJzVHrIsQ43bJs=; b=aWZpvG0XSaMOGwuVFeymW3t+XEVflfaE4zPHuCSwiZglsDZvXrYv/kdSXaNI3IuX1g1aXt 4cuSMkgS3rcQxWg18MTVSJ1ssqo3GUTLcMn3ha4FnwEOVo1Ysng94WNi8Xp9SXtk/EjYjm f6wCPpuuJ6bpwEX9o6Kn7OlB59QCleg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-603-Q2YsiAoAPcSkrUNGkjLMkg-1; Sat, 13 Mar 2021 04:33:10 -0500 X-MC-Unique: Q2YsiAoAPcSkrUNGkjLMkg-1 Received: by mail-wm1-f72.google.com with SMTP id z26so6311553wml.4 for ; Sat, 13 Mar 2021 01:33:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0Tdndx9aurgi/5sVvvOA/y0ZDMqTihJzVHrIsQ43bJs=; b=Fr4FJsKhpdcbYvchPF6tyNFD2CDqefRY92SKLFIw3PzcpKXV3dkKUipNc3Nk5Ui1KL MFRUQ1eUj0VRhRFJQ3MSyUnZKH0uODtieiC8JjJeWCxT2Nnl/w2eZcCEb2ayH8owAcMY JV6y7SbsZhflf6y59XLNmYp1+Uf2RF8QQ1rxJOyK487J0i1NWTHFGh1u1YydQe5Fylt/ +oBu5hN4fx+FF1Q8FA7HxJK62kxRXDFkqOPIU9K9OF4JRqLsYpTCsKmMCUxhW17YZ0ta D3ChFhueD2M43reAJJOqyFnpA2dzSKHzoTHMD/DD257J6DQAetloeh7+5T3hSY6LyqvW agMg== X-Gm-Message-State: AOAM533sR7gqrs5wTFdavlXLQ7SN5lTN7MxnRXxsBSstYoEis8o5v212 FKn8l8bBEgfwU6cqDqiuGxB2b4QJrzG7zsSTl2U3gqASEl5DyaIne4y3fnAlamFNKqCekPxvqxf HGV+vh6p/TkQahuFJABR70cOu X-Received: by 2002:adf:e412:: with SMTP id g18mr18584081wrm.159.1615627988831; Sat, 13 Mar 2021 01:33:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzg3FRJBBi6VfIDfkhCbsogqZme7WQaI6CDyHC5QxwaLbcrsXWQe1OD25UKJ9/fEcTaTGceHw== X-Received: by 2002:adf:e412:: with SMTP id g18mr18584073wrm.159.1615627988716; Sat, 13 Mar 2021 01:33:08 -0800 (PST) Received: from [192.168.1.124] ([93.56.170.5]) by smtp.gmail.com with ESMTPSA id u17sm3646875wmq.3.2021.03.13.01.33.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Mar 2021 01:33:07 -0800 (PST) Subject: Re: [PATCH] x86/kvm: Fix broken irq restoration in kvm_wait To: Wanpeng Li , Sean Christopherson Cc: LKML , kvm , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Mark Rutland , Thomas Gleixner References: <1614057902-23774-1-git-send-email-wanpengli@tencent.com> From: Paolo Bonzini Message-ID: Date: Sat, 13 Mar 2021 10:29:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/03/21 01:57, Wanpeng Li wrote: >> A third option would be to split the paths. In the end, it's only the ptr/val >> line that's shared. > I just sent out a formal patch for my alternative fix, I think the > whole logic in kvm_wait is more clear w/ my version. > I don't know, having three "if"s in 10 lines of code is a bit daunting. Paolo