Re: [PATCH v8 15/18] nitro_enclaves: Add Makefile for the Nitro Enclaves driver - Paraschiv, Andra-Irina

From: "Paraschiv, Andra-Irina" <andraprs@amazon.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Anthony Liguori <aliguori@amazon.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Colm MacCarthaigh <colmmacc@amazon.com>,
	David Duncan <davdunc@amazon.com>,
	Bjoern Doebel <doebel@amazon.de>,
	David Woodhouse <dwmw@amazon.co.uk>,
	"Frank van der Linden" <fllinden@amazon.com>,
	Alexander Graf <graf@amazon.de>, "Karen Noel" <knoel@redhat.com>,
	Martin Pohlack <mpohlack@amazon.de>, Matt Wilson <msw@amazon.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Balbir Singh <sblbir@amazon.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	Stewart Smith <trawets@amazon.com>,
	"Uwe Dannowski" <uwed@amazon.de>,
	Vitaly Kuznetsov <vkuznets@redhat.com>, kvm <kvm@vger.kernel.org>,
	ne-devel-upstream <ne-devel-upstream@amazon.com>
Subject: Re: [PATCH v8 15/18] nitro_enclaves: Add Makefile for the Nitro Enclaves driver
Date: Mon, 7 Sep 2020 18:05:23 +0300	[thread overview]
Message-ID: <e3891965-758b-7caf-0699-d182f4951cc4@amazon.com> (raw)
In-Reply-To: <20200907140841.GB3719869@kroah.com>

On 07/09/2020 17:08, Greg KH wrote:
>
> On Mon, Sep 07, 2020 at 04:35:23PM +0300, Paraschiv, Andra-Irina wrote:
>>
>> On 07/09/2020 12:00, Greg KH wrote:
>>>
>>> On Fri, Sep 04, 2020 at 08:37:15PM +0300, Andra Paraschiv wrote:
>>>> Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
>>>> Reviewed-by: Alexander Graf <graf@amazon.com>
>>>> ---
>>>> Changelog
>>>>
>>>> v7 -> v8
>>>>
>>>> * No changes.
>>>>
>>>> v6 -> v7
>>>>
>>>> * No changes.
>>>>
>>>> v5 -> v6
>>>>
>>>> * No changes.
>>>>
>>>> v4 -> v5
>>>>
>>>> * No changes.
>>>>
>>>> v3 -> v4
>>>>
>>>> * No changes.
>>>>
>>>> v2 -> v3
>>>>
>>>> * Remove the GPL additional wording as SPDX-License-Identifier is
>>>>     already in place.
>>>>
>>>> v1 -> v2
>>>>
>>>> * Update path to Makefile to match the drivers/virt/nitro_enclaves
>>>>     directory.
>>>> ---
>>>>    drivers/virt/Makefile                |  2 ++
>>>>    drivers/virt/nitro_enclaves/Makefile | 11 +++++++++++
>>>>    2 files changed, 13 insertions(+)
>>>>    create mode 100644 drivers/virt/nitro_enclaves/Makefile
>>>>
>>>> diff --git a/drivers/virt/Makefile b/drivers/virt/Makefile
>>>> index fd331247c27a..f28425ce4b39 100644
>>>> --- a/drivers/virt/Makefile
>>>> +++ b/drivers/virt/Makefile
>>>> @@ -5,3 +5,5 @@
>>>>
>>>>    obj-$(CONFIG_FSL_HV_MANAGER) += fsl_hypervisor.o
>>>>    obj-y                                += vboxguest/
>>>> +
>>>> +obj-$(CONFIG_NITRO_ENCLAVES) += nitro_enclaves/
>>>> diff --git a/drivers/virt/nitro_enclaves/Makefile b/drivers/virt/nitro_enclaves/Makefile
>>>> new file mode 100644
>>>> index 000000000000..e9f4fcd1591e
>>>> --- /dev/null
>>>> +++ b/drivers/virt/nitro_enclaves/Makefile
>>>> @@ -0,0 +1,11 @@
>>>> +# SPDX-License-Identifier: GPL-2.0
>>>> +#
>>>> +# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
>>>> +
>>>> +# Enclave lifetime management support for Nitro Enclaves (NE).
>>>> +
>>>> +obj-$(CONFIG_NITRO_ENCLAVES) += nitro_enclaves.o
>>>> +
>>>> +nitro_enclaves-y := ne_pci_dev.o ne_misc_dev.o
>>>> +
>>>> +ccflags-y += -Wall
>>> That flag is _really_ risky over time, are you _SURE_ that all new
>>> versions of clang and gcc will never produce any warnings?  People work
>>> to fix up build warnings quite quickly for new compilers, you shouldn't
>>> prevent the code from being built at all just for that, right?
>>>
>> That would also need Werror, to have warnings treated as errors and prevent
>> building the codebase. If it's about something more, just let me know.
> No, you are right, Werror would be needed here too.
>
> W=1 gives you -Wall if you really want that, no need to add it by hand.

Good, we are on the some page then. :) Thanks for the heads-up with 
regard to the W=1 option.

Andra

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.