From: Daniel Bristot de Oliveira <daolivei@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
Subject: Re: [RFC PATCH 2/2] sched: sysctl: Panic on scheduling while atomic
Date: Wed, 1 Jun 2016 10:37:11 -0300 [thread overview]
Message-ID: <e38a7f99-b3d1-adaf-26b3-800a6628d98f@redhat.com> (raw)
In-Reply-To: <20160601094544.GP3190@twins.programming.kicks-ass.net>
On 06/01/2016 06:45 AM, Peter Zijlstra wrote:
> Do we really need more panic_on_* knobs? Can't we re-purpose
> panic_on_warn for this?
I think this case is very specific, specific enough to deserve its own
sysctl. But I see your point, and the possibilities I can see are:
1) convert the printk(KERN_ERR "BUG:...") to a WARN(1,"BUG:..."), but
this will hide all other information printed in the function, so -1 for
this option;
2) fire a WARN in the end of the function with a message like the
previous printk(); or
3) re-use the panic_on_warn variable to condition the panic,
or to force a WARN.
But, IMHO, I think these are not as polish as use a specific sysctl.
If you think that any of these options are better than what I propose,
I can cook a v2 with the best option :-).
-- Daniel
next prev parent reply other threads:[~2016-06-01 13:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 19:07 [RFC PATCH 0/2] sysctl: Panic on RCU stall and schedule while atomic Daniel Bristot de Oliveira
2016-05-31 19:07 ` [RFC PATCH 1/2] rcu: sysctl: Panic on RCU Stall Daniel Bristot de Oliveira
2016-05-31 19:18 ` Josh Triplett
2016-05-31 19:23 ` Josh Triplett
2016-05-31 22:49 ` Daniel Bristot de Oliveira
2016-06-01 2:34 ` Paul E. McKenney
2016-05-31 19:07 ` [RFC PATCH 2/2] sched: sysctl: Panic on scheduling while atomic Daniel Bristot de Oliveira
2016-05-31 19:20 ` Josh Triplett
2016-06-01 9:45 ` Peter Zijlstra
2016-06-01 13:37 ` Daniel Bristot de Oliveira [this message]
2016-05-31 19:27 ` [RFC PATCH 0/2] sysctl: Panic on RCU stall and schedule " Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e38a7f99-b3d1-adaf-26b3-800a6628d98f@redhat.com \
--to=daolivei@redhat.com \
--cc=acme@kernel.org \
--cc=corbet@lwn.net \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).