From: Neil Armstrong <narmstrong@baylibre.com>
To: Sandor.yu@nxp.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, andrzej.hajda@intel.com,
robert.foss@linaro.org, Laurent.pinchart@ideasonboard.com,
jonas@kwiboo.se, jernej.skrabec@gmail.com,
hverkuil-cisco@xs4all.nl
Cc: shengjiu.wang@nxp.com, cai.huoqing@linux.dev, maxime@cerno.tech,
harry.wentland@amd.com
Subject: Re: [PATCH v3 2/4] drm: bridge: dw_hdmi: Enable GCP only for Deep Color
Date: Fri, 15 Apr 2022 09:08:58 +0200 [thread overview]
Message-ID: <e38e8450-94c5-90f6-207e-07af972f3ed0@baylibre.com> (raw)
In-Reply-To: <78fa41e4fb3d3d53354034bc221fcf870dbac617.1649989179.git.Sandor.yu@nxp.com>
On 15/04/2022 04:42, Sandor.yu@nxp.com wrote:
> From: Sandor Yu <Sandor.yu@nxp.com>
>
> HDMI1.4b specification section 6.5.3:
> Source shall only send GCPs with non-zero CD to sinks
> that indicate support for Deep Color.
>
> DW HDMI GCP default enabled, but only transmit CD
> and do not handle AVMUTE, PP norDefault_Phase (yet).
> Disable Auto GCP when 24-bit color for sinks that not support Deep Color.
>
> Signed-off-by: Sandor Yu <Sandor.yu@nxp.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 17 +++++++++++++++++
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 3 +++
> 2 files changed, 20 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 02d8f7e08814..312500921754 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1108,6 +1108,8 @@ static void hdmi_video_packetize(struct dw_hdmi *hdmi)
> unsigned int output_select = HDMI_VP_CONF_OUTPUT_SELECTOR_PP;
> struct hdmi_data_info *hdmi_data = &hdmi->hdmi_data;
> u8 val, vp_conf;
> + u8 clear_gcp_auto = 0;
> +
>
> if (hdmi_bus_fmt_is_rgb(hdmi->hdmi_data.enc_out_bus_format) ||
> hdmi_bus_fmt_is_yuv444(hdmi->hdmi_data.enc_out_bus_format) ||
> @@ -1117,6 +1119,7 @@ static void hdmi_video_packetize(struct dw_hdmi *hdmi)
> case 8:
> color_depth = 4;
> output_select = HDMI_VP_CONF_OUTPUT_SELECTOR_BYPASS;
> + clear_gcp_auto = 1;
> break;
> case 10:
> color_depth = 5;
> @@ -1136,6 +1139,7 @@ static void hdmi_video_packetize(struct dw_hdmi *hdmi)
> case 0:
> case 8:
> remap_size = HDMI_VP_REMAP_YCC422_16bit;
> + clear_gcp_auto = 1;
> break;
> case 10:
> remap_size = HDMI_VP_REMAP_YCC422_20bit;
> @@ -1160,6 +1164,19 @@ static void hdmi_video_packetize(struct dw_hdmi *hdmi)
> HDMI_VP_PR_CD_DESIRED_PR_FACTOR_MASK);
> hdmi_writeb(hdmi, val, HDMI_VP_PR_CD);
>
> + /* HDMI1.4b specification section 6.5.3:
> + * Source shall only send GCPs with non-zero CD to sinks
> + * that indicate support for Deep Color.
> + * GCP only transmit CD and do not handle AVMUTE, PP norDefault_Phase (yet).
> + * Disable Auto GCP when 24-bit color for sinks that not support Deep Color.
> + */
> + val = hdmi_readb(hdmi, HDMI_FC_DATAUTO3);
> + if (clear_gcp_auto == 1)
> + val &= ~HDMI_FC_DATAUTO3_GCP_AUTO;
> + else
> + val |= HDMI_FC_DATAUTO3_GCP_AUTO;
> + hdmi_writeb(hdmi, val, HDMI_FC_DATAUTO3);
> +
> hdmi_modb(hdmi, HDMI_VP_STUFF_PR_STUFFING_STUFFING_MODE,
> HDMI_VP_STUFF_PR_STUFFING_MASK, HDMI_VP_STUFF);
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.h b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.h
> index 1999db05bc3b..18df3e119553 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.h
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.h
> @@ -850,6 +850,9 @@ enum {
> HDMI_FC_DATAUTO0_VSD_MASK = 0x08,
> HDMI_FC_DATAUTO0_VSD_OFFSET = 3,
>
> +/* FC_DATAUTO3 field values */
> + HDMI_FC_DATAUTO3_GCP_AUTO = 0x04,
> +
> /* PHY_CONF0 field values */
> HDMI_PHY_CONF0_PDZ_MASK = 0x80,
> HDMI_PHY_CONF0_PDZ_OFFSET = 7,
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
next prev parent reply other threads:[~2022-04-15 7:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 2:42 [PATCH v3 0/4] DRM: Bridge: DW_HDMI: Add new features and bug fix Sandor.yu
2022-04-15 2:42 ` [PATCH v3 1/4] drm: bridge: dw_hdmi: default enable workaround to clear the overflow Sandor.yu
2022-04-15 2:42 ` [PATCH v3 2/4] drm: bridge: dw_hdmi: Enable GCP only for Deep Color Sandor.yu
2022-04-15 7:08 ` Neil Armstrong [this message]
2022-04-15 2:42 ` [PATCH v3 3/4] drm: bridge: dw_hdmi: add reset function for PHY GEN1 Sandor.yu
2022-04-15 2:42 ` [PATCH v3 4/4] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver Sandor.yu
2022-04-15 7:11 ` Neil Armstrong
2022-04-19 16:32 ` [PATCH v3 0/4] DRM: Bridge: DW_HDMI: Add new features and bug fix Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e38e8450-94c5-90f6-207e-07af972f3ed0@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=Sandor.yu@nxp.com \
--cc=andrzej.hajda@intel.com \
--cc=cai.huoqing@linux.dev \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=robert.foss@linaro.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).