From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A93C433F5 for ; Mon, 31 Jan 2022 13:12:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378606AbiAaNMv (ORCPT ); Mon, 31 Jan 2022 08:12:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378798AbiAaNMu (ORCPT ); Mon, 31 Jan 2022 08:12:50 -0500 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5DAAC061714; Mon, 31 Jan 2022 05:12:49 -0800 (PST) Received: from [2a04:4540:1400:f600:38a4:8fb:af3f:40b1] by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nEWU3-0006KS-Hy; Mon, 31 Jan 2022 14:12:39 +0100 Message-ID: Date: Mon, 31 Jan 2022 14:12:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v9 03/13] ARM: Add basic support for Airoha EN7523 SoC Content-Language: en-GB To: Robert Marko , Felix Fietkau Cc: Luka Perkov , Russell King , Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, Linux ARM , Linux Kernel Mailing List , devicetree References: <20220130145116.88406-1-nbd@nbd.name> <20220130145116.88406-4-nbd@nbd.name> <04c91b4e-e7c8-ac6a-f60a-0453a49122fa@nbd.name> From: John Crispin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31.01.22 14:00, Robert Marko wrote: > On Mon, Jan 31, 2022 at 1:57 PM Felix Fietkau wrote: >> >> >> On 31.01.22 11:51, Luka Perkov wrote: >>> Hello Felix, >>> >>> On Sun, Jan 30, 2022 at 3:56 PM Felix Fietkau wrote: >>>> >>>> From: John Crispin >>>> >>>> EN7523 is an armv8 based silicon used inside broadband access type devices >>>> such as xPON and xDSL. It shares various silicon blocks with MediaTek >>>> silicon such as the MT7622. >>>> >>>> Add basic support for Airoha EN7523, enough for booting to console. >>>> >>>> The UART is basically 8250-compatible, except for the clock selection. >>>> A clock-frequency value is synthesized to get this to run at 115200 bps. >>>> >>>> Signed-off-by: John Crispin >>>> Signed-off-by: Bert Vermeulen >>>> Signed-off-by: Felix Fietkau >>>> --- >>>> index 000000000000..ea23b5abb478 >>>> --- /dev/null >>>> +++ b/arch/arm/mach-airoha/airoha.c >>>> @@ -0,0 +1,16 @@ >>>> +// SPDX-License-Identifier: GPL-2.0-or-later >>>> +/* >>>> + * Device Tree support for Airoha SoCs >>>> + * >>>> + * Copyright (c) 2022 Felix Fietkau >>>> + */ >>>> +#include >>>> + >>>> +static const char * const airoha_board_dt_compat[] = { >>>> + "airoha,en7523", >>>> + NULL, >>>> +}; >>>> + >>>> +DT_MACHINE_START(MEDIATEK_DT, "Airoha Cortex-A53 (Device Tree)") >>> >>> Since this is Cortex-A53 core is there a reason why this is not placed >>> within arm64 directory? >> From what I can tell, it's a stripped-down core that only runs in >> 32-bit mode. > > Hmm, this is new for me that you could do that to an ARMv8 (A53) core. > I know that you can run ARMv7 code but not that you can reduce it to > 32 bit only. > > Regards, > Robert the bootrom and vendor bootloader do not support 64bit more. John