From: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: <agross@kernel.org>, <bgoswami@quicinc.com>,
<bjorn.andersson@linaro.org>, <broonie@kernel.org>,
<devicetree@vger.kernel.org>, <judyhsiao@chromium.org>,
<lgirdwood@gmail.com>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>, <perex@perex.cz>,
<quic_plai@quicinc.com>, <quic_rohkumar@quicinc.com>,
<robh+dt@kernel.org>, <srinivas.kandagatla@linaro.org>,
<swboyd@chromium.org>, <tiwai@suse.com>
Subject: Re: [PATCH 7/8] remoteproc: qcom: Add support for memory sandbox
Date: Tue, 9 Aug 2022 12:04:35 +0530 [thread overview]
Message-ID: <e3e087ba-b6d8-981f-e22f-cadd557c35af@quicinc.com> (raw)
In-Reply-To: <2729cd6f-17ff-70d8-52c5-3dceb93e6a82@wanadoo.fr>
On 8/7/2022 2:09 AM, Christophe JAILLET wrote:
Thanks for Your Time CJ!!!
> Hi,
>
> the error handling below looks odd.
>
> Le 03/08/2022 à 16:21, Srinivasa Rao Mandadapu a écrit :
>> Add memory sandbox support for ADSP based platforms secure booting.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu
>> <quic_srivasam-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org>
>> ---
>> drivers/remoteproc/qcom_q6v5_adsp.c | 101
>> +++++++++++++++++++++++++++++++++++-
>> 1 file changed, 99 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c
>> b/drivers/remoteproc/qcom_q6v5_adsp.c
>> index 3dbd035..f81da47 100644
>> --- a/drivers/remoteproc/qcom_q6v5_adsp.c
>> +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
>
>> static int adsp_start(struct rproc *rproc)
>> {
>> struct qcom_adsp *adsp = (struct qcom_adsp *)rproc->priv;
>> @@ -341,7 +429,13 @@ static int adsp_start(struct rproc *rproc)
>> ret = qcom_q6v5_prepare(&adsp->q6v5);
>> if (ret)
>> return ret;
>> -
>> + if (!adsp->is_wpss) {
>> + ret = adsp_map_smmu(adsp, rproc);
>> + if (ret) {
>> + dev_err(adsp->dev, "ADSP smmu mapping failed\n");
>> + goto adsp_smmu_unmap;
> goto disable_irqs;?
Yes. will correct it accordingly.
>
>> + }
>> + }
>> ret = clk_prepare_enable(adsp->xo);
>> if (ret)
>> goto disable_irqs;
>
> goto adsp_smmu_unmap;?
Yes. will correct it accordingly.
>
>> @@ -402,6 +496,9 @@ static int adsp_start(struct rproc *rproc)
>> clk_disable_unprepare(adsp->xo);
>> disable_irqs:
>> qcom_q6v5_unprepare(&adsp->q6v5);
>> +adsp_smmu_unmap:
>> + iommu_unmap(adsp->iommu_dom, adsp->mem_phys, adsp->mem_size);
>> + iommu_domain_free(adsp->iommu_dom);
>
> Should this new hunk be above disable_irqs?
> And I think that it should be guardd with a "if (!adsp->is_wpss)".
Yes. will correct it accordingly.
>
> CJ
>
>> return ret;
>> }
>
next prev parent reply other threads:[~2022-08-09 6:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 14:21 [PATCH 0/8] Update ADSP pil loader for SC7280 platform Srinivasa Rao Mandadapu
2022-08-03 14:21 ` [PATCH 1/8] dt-bindings: remoteproc: qcom: adsp: Make ADSP pil loader as generic Srinivasa Rao Mandadapu
2022-08-04 19:47 ` Caleb Connolly
2022-08-09 9:51 ` Srinivasa Rao Mandadapu
2022-08-03 14:21 ` [PATCH 2/8] dt-bindings: remoteproc: qcom: adsp: Add compatible name for SC7280 Srinivasa Rao Mandadapu
2022-08-03 20:34 ` Rob Herring
2022-08-03 20:43 ` Rob Herring
2022-08-04 10:14 ` Srinivasa Rao Mandadapu
2022-08-03 14:21 ` [PATCH 3/8] remoteproc: qcom: Add compatible name for SC7280 ADSP Srinivasa Rao Mandadapu
2022-08-06 20:57 ` Dmitry Baryshkov
2022-08-09 9:49 ` Srinivasa Rao Mandadapu
2022-08-03 14:21 ` [PATCH 4/8] remoteproc: qcom: Update hard coded values with macros Srinivasa Rao Mandadapu
2022-08-06 20:24 ` Dmitry Baryshkov
2022-08-03 14:21 ` [PATCH 5/8] remoteproc: qcom: Add efuse evb selection control Srinivasa Rao Mandadapu
2022-08-06 20:26 ` Dmitry Baryshkov
2022-08-09 6:31 ` Srinivasa Rao Mandadapu
2022-08-03 14:21 ` [PATCH 6/8] remoteproc: qcom: Add flag in adsp private data structure Srinivasa Rao Mandadapu
2022-08-03 14:21 ` [PATCH 7/8] remoteproc: qcom: Add support for memory sandbox Srinivasa Rao Mandadapu
2022-08-06 20:34 ` Dmitry Baryshkov
2022-08-09 8:22 ` Srinivasa Rao Mandadapu
2022-08-09 11:04 ` Srinivasa Rao Mandadapu
2022-08-06 20:39 ` Christophe JAILLET
2022-08-09 6:34 ` Srinivasa Rao Mandadapu [this message]
2022-08-03 14:21 ` [PATCH 8/8] remoteproc: qcom: Update QDSP6 out-of-reset timeout value Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3e087ba-b6d8-981f-e22f-cadd557c35af@quicinc.com \
--to=quic_srivasam@quicinc.com \
--cc=agross@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).