From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DBBC46464 for ; Fri, 10 Aug 2018 08:41:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A836223FA for ; Fri, 10 Aug 2018 08:41:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ha0nZDo0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A836223FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727746AbeHJLKq (ORCPT ); Fri, 10 Aug 2018 07:10:46 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32777 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726996AbeHJLKq (ORCPT ); Fri, 10 Aug 2018 07:10:46 -0400 Received: by mail-wm0-f68.google.com with SMTP id r24-v6so856281wmh.0 for ; Fri, 10 Aug 2018 01:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EPth9GptfFUebQvbEelxragDP2eSq1lOsVSqbURirDY=; b=Ha0nZDo0son3vThBsdLg5J26fLu5pyhfpYlVfvMKvweVP4Od/1wb/sC9wpjVfvtWFe NrlcNiuT0YyerBizDN2NhpG2T8XCO9HXpVqouEiBU+flOk0sIAiC1lQ61VJpvA8PmZbq rpe2yT7sSZrjzRapx5L4nZ7iyGJ4dojzPeeOQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EPth9GptfFUebQvbEelxragDP2eSq1lOsVSqbURirDY=; b=VtdsaMxUepD/yrF5wAfKT0tgxl9pBEQbikCjVX0U747gPWaPsdoD5Mtj4ax021TuxO AqiAu+rv+Xnm93AUAsmdyB8F/ULmerJoMybTdftqq1WT9V5Er8PBRtrdaeN3I6oeCdyM VaLzFD8OHWFry+xk4rVVPR9cwUY79x1U/JR8T7TG18DeILjaXDVuNm8LT7suOYf7C9kv Jh0df/T8p9QxJ7XDXoi8p6iflVZAjjtaSj36zd0OHqaQnRwcIoQkXGJWKYnbbqVy+88s s2RkPDQZ2OMmcGLZOPpaZt7W+mskUC8a+a4eCQdP5ANULdj+ypXiCu5VPGWUbXsbRyio Ncig== X-Gm-Message-State: AOUpUlGeU8c2Tvpu4DQndA7sqGslEECQUGgzDDEDBYWnvw9aVVj2xci3 PApAcm56UPq9TdXQznrAzAf2lQ== X-Google-Smtp-Source: AA+uWPxEuMLO7+RBZD+PxViAzcqs+O13xVqj3FmV7+uIyKcUie2lkAPxTmUKDSQ6q0hDDNM4K0ToPA== X-Received: by 2002:a1c:357:: with SMTP id 84-v6mr849629wmd.8.1533890511435; Fri, 10 Aug 2018 01:41:51 -0700 (PDT) Received: from [192.168.0.18] (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.googlemail.com with ESMTPSA id m35-v6sm12180272wrf.41.2018.08.10.01.41.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Aug 2018 01:41:50 -0700 (PDT) Subject: Re: [PATCH v2 00/29] at24: remove at24_platform_data To: Bartosz Golaszewski , Jonathan Corbet , Sekhar Nori , Kevin Hilman , Russell King , Arnd Bergmann , Greg Kroah-Hartman , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Grygorii Strashko , "David S . Miller" , Naren , Mauro Carvalho Chehab , Andrew Morton , Lukas Wunner , Dan Carpenter , Florian Fainelli , Ivan Khoronzhuk , Sven Van Asbroeck , Paolo Abeni , Alban Bedel , Rob Herring , David Lechner , Andrew Lunn Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, netdev@vger.kernel.org, Bartosz Golaszewski References: <20180810080526.27207-1-brgl@bgdev.pl> From: Srinivas Kandagatla Message-ID: Date: Fri, 10 Aug 2018 09:41:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180810080526.27207-1-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/18 09:04, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This is a follow-up to the previously rejected series[1] which partially > removed the at24_platform_data structure. After further development and > taking reviews into account, this series finally removes that struct > completely but not without touching many different parts of the code > base. > > Since I took over maintainership of the at24 driver I've been working > towards removing at24_platform_data in favor for device properties. > > DaVinci is the only platform that's still using it - all other users > have already been converted. > > One of the obstacles in case of DaVinci is removing the setup() callback > from the pdata struct, the only user of which are some davinci boards. > > Most boards use the EEPROM to store the MAC address. This series adds > support for cell lookups to the nvmem framework, registers relevant > cells for all users, adds nvmem support to eth_platform_get_mac_address(), > converts davinci_emac driver to using it and replaces at24_platform_data > with device properties. > > There's also one board (da850-evm) which uses MTD for reading the MAC > address. I used the patch from Alban Bedel's previous submission[2] to > add support for nvmem to the MTD framework. Since this user doesn't > need device tree, I dropped Alban's patches modifying the DT bindings. > We can add that later once an agreement is reached. For the time being > MTD devices are registered as nvmem devices and we're registering the > mac-address cell using the cell lookup mechanism. > > This series adds a blocking notifier chain to the nvmem framework, so > that we can keep the EEPROM reading code in the mityomapl138 board file > with only slight modifications. > > I also included some minor fixes to the modified code. > > Tested on da850-evm & dm365-evm. > > [1] https://lkml.org/lkml/2018/6/29/153 > [2] https://lkml.org/lkml/2018/3/24/312 > ... > Bartosz Golaszewski (28): > nvmem: add support for cell lookups > Documentation: nvmem: document lookup entries > nvmem: add a notifier chain > nvmem: provide nvmem_dev_name() > nvmem: remove the name field from struct nvmem_device > > Documentation/nvmem/nvmem.txt | 28 +++++ .. > drivers/nvmem/core.c | 106 ++++++++++++++++- nvmem parts looks good to me other then few trivial kernel doc comments! I can either Ack those patches or Send them after rc3-4 to Greg KH as 4.20 material. Thanks srini >