From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D9C9C4320A for ; Tue, 27 Jul 2021 11:32:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AFD6619F8 for ; Tue, 27 Jul 2021 11:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236487AbhG0Lcg (ORCPT ); Tue, 27 Jul 2021 07:32:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60943 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231781AbhG0Lce (ORCPT ); Tue, 27 Jul 2021 07:32:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627385554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BaUI7/MGdUeu9aK6r/10GV5Uw/sttnvzMU+KPJUYtJ4=; b=IeLsWQ71nujWHdwLWStdGoic4AcBqVmxe7iXXIYmGL6Cy2d7wdmmFpV3/EVeAoj4YQe5cK pe8/Hka8HTbIJISJMuax6FcxQKz2sJiUhm9/c6hucq9GGIN6AAYUK4G8pJutg5aWGmSV0J qCoTbkhkx4gCo1+lkiuQ55rqY6AaGuQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-QNTFJodkPi2JetmD8jM5cQ-1; Tue, 27 Jul 2021 07:32:33 -0400 X-MC-Unique: QNTFJodkPi2JetmD8jM5cQ-1 Received: by mail-wm1-f70.google.com with SMTP id j204-20020a1c23d50000b029024e75a15714so1263436wmj.0 for ; Tue, 27 Jul 2021 04:32:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BaUI7/MGdUeu9aK6r/10GV5Uw/sttnvzMU+KPJUYtJ4=; b=GwPXRHwKL3mE/oga9jNQVjvmdLUoEkAeDxAARqmE2TmLeu0BvQ71E+Iiegip8Z8KeD IQF3OGXB9hoF37Z1GJjF6jXt1H+5vrf2sP13Hkp+jpRfgFVUKwbhHkjFsc8Q8sUUjUdV /NdQzk1+3bmQbU1rGi5GODejcU6Dt+wAbu4wOGmkhT2i5MwRNkItsnb3kT1SaDljhiIu 9Mmoy3a2RFlZO8yw0GFMeEZOvZGeuRitQmuXivgIa6BiCzw6khVcSa1uIlrxv0ZDG7Ws LPZj3EHCQeFy4VxwvsFOKtYsGMLMYR6Xgh8Ah7Q3r+HEMwruuWJI6Jjeae6KWRgvKK7j clCw== X-Gm-Message-State: AOAM533RNwMptApeanBefSpk11Rh4onGO8c1VS/vUJds7nfINbFUM3FL 4bJsZzpBXlXB0SurGzrxNukaDbjZfPtxSl1OG9ELvQYC+i6dP6YmDqijl39PE0MNgcIJv+wVGDC ijxSCBs+xKREo7+H2hywcOFWQ X-Received: by 2002:a05:600c:354a:: with SMTP id i10mr3625986wmq.171.1627385551913; Tue, 27 Jul 2021 04:32:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhE4cnozKr8xVw/EzcVfHMxN7aC5PXugco7yEF7nBIklqrOTaYs+t5SrVxBZFKP7Pap/DUZQ== X-Received: by 2002:a05:600c:354a:: with SMTP id i10mr3625962wmq.171.1627385551713; Tue, 27 Jul 2021 04:32:31 -0700 (PDT) Received: from [192.168.1.101] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id t16sm2455697wmj.16.2021.07.27.04.32.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jul 2021 04:32:30 -0700 (PDT) Subject: Re: [PATCH v2] drivers/firmware: fix SYSFB depends to prevent build failures To: Geert Uytterhoeven Cc: Linux Kernel Mailing List , Thomas Zimmermann , dri-devel , Peter Robinson , Mark Brown , kernel test robot , Borislav Petkov , Colin Ian King , Daniel Vetter , Dinh Nguyen , Greg Kroah-Hartman , John Stultz , Krzysztof Kozlowski , Linus Walleij , Nicolas Saenz Julienne , Sudeep Holla References: <20210727093015.1225107-1-javierm@redhat.com> From: Javier Martinez Canillas Message-ID: Date: Tue, 27 Jul 2021 13:32:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/27/21 1:17 PM, Geert Uytterhoeven wrote: [snip] >> Not enabling this, would mean that a platform device to match a driver >> supporting the EFI GOP framebuffer (e.g: simple{drm,fb} or efifb) will >> not be registered. Which will lead to not having an early framebuffer. > > Do all (embedded) EFI systems have a frame buffer? > That's a good question. I don't know if all EFI firmwares are expected to provide a GOP or not. But even the u-boot EFI stub provides one, if video output is supported by u-boot on that system. > Perhaps SYSFB should be selected by SYSFB_SIMPLEFB, FB_VESA, > and FB_EFI? > It's another option, yes. I just thought that the use of select was not encouraged and using depends was less fragile / error prone. >> The logic used to be in drivers/firmware/efi/efi-init.c, that's built >> in if CONFIG_EFI is enabled. We just consolidated both X86 and EFI: >> >> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8633ef82f101 > > Thanks, I'm aware of that commit, as I was just about to reply to it, > when I saw the patch is this thread ;-) > Ok :) Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat