From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E8DC56202 for ; Fri, 13 Nov 2020 19:45:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24985208B6 for ; Fri, 13 Nov 2020 19:45:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="RiTnzAQl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726455AbgKMTpu (ORCPT ); Fri, 13 Nov 2020 14:45:50 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:36031 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbgKMTpt (ORCPT ); Fri, 13 Nov 2020 14:45:49 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1605296749; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=/yWkcPTIQsfeWoQXHfqsMxaK6CtFGnKWHzbg1QN52pM=; b=RiTnzAQlDnFmkTPMQ7Y/BCb4jG7u0W+k2IGYVxXcQDCQbX+Y5Lu7U/LuAJyhQGbh3XR4ww/+ YjDdawo0qsU0cm30uuEQdAn2rw41exiA3+F76UUA4q7wMAhJIFLIXg9cZ6m4MKmXJGYEZpvJ LgwGOfM8smWhrezALjgumIYQ9u8= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n09.prod.us-west-2.postgun.com with SMTP id 5faee25ae9dd187f532d168c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 13 Nov 2020 19:45:30 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9992FC433FE; Fri, 13 Nov 2020 19:45:30 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id E1E95C433CB; Fri, 13 Nov 2020 19:45:29 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 13 Nov 2020 11:45:29 -0800 From: abhinavk@codeaurora.org To: Lee Jones Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Clark , Daniel Vetter , Sean Paul Subject: Re: [Freedreno] [PATCH 34/40] drm/msm/disp/mdp5/mdp5_ctl: Demote non-conformant kernel-doc headers In-Reply-To: <20201113134938.4004947-35-lee.jones@linaro.org> References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-35-lee.jones@linaro.org> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-13 05:49, Lee Jones wrote: > Very little attempt has been made to document these functions. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227: warning: Function > parameter or member 'ctl' not described in > 'mdp5_ctl_set_encoder_state' > drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227: warning: Function > parameter or member 'pipeline' not described in > 'mdp5_ctl_set_encoder_state' > drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227: warning: Function > parameter or member 'enabled' not described in > 'mdp5_ctl_set_encoder_state' > drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227: warning: Excess > function parameter 'enable' description in > 'mdp5_ctl_set_encoder_state' > drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:529: warning: Function > parameter or member 'ctl' not described in 'mdp5_ctl_commit' > drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:529: warning: Function > parameter or member 'pipeline' not described in 'mdp5_ctl_commit' > drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:529: warning: Function > parameter or member 'flush_mask' not described in 'mdp5_ctl_commit' > drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:529: warning: Function > parameter or member 'start' not described in 'mdp5_ctl_commit' > > Cc: Rob Clark > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Lee Jones Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c > b/drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c > index 030279d7b64b7..b5c40f9773629 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c > @@ -213,10 +213,10 @@ static void send_start_signal(struct mdp5_ctl > *ctl) > spin_unlock_irqrestore(&ctl->hw_lock, flags); > } > > -/** > +/* > * mdp5_ctl_set_encoder_state() - set the encoder state > * > - * @enable: true, when encoder is ready for data streaming; false, > otherwise. > + * @enabled: true, when encoder is ready for data streaming; false, > otherwise. > * > * Note: > * This encoder state is needed to trigger START signal (data path > kickoff). > @@ -507,7 +507,7 @@ static void fix_for_single_flush(struct mdp5_ctl > *ctl, u32 *flush_mask, > } > } > > -/** > +/* > * mdp5_ctl_commit() - Register Flush > * > * The flush register is used to indicate several registers are all