From: Tushar Sugandhi <tusharsu@linux.microsoft.com>
To: Mimi Zohar <zohar@linux.ibm.com>,
stephen.smalley.work@gmail.com, casey@schaufler-ca.com,
agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com,
paul@paul-moore.com
Cc: tyhicks@linux.microsoft.com, sashal@kernel.org,
jmorris@namei.org, nramas@linux.microsoft.com,
linux-integrity@vger.kernel.org, selinux@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [PATCH v9 2/8] IMA: add support to measure buffer data hash
Date: Tue, 5 Jan 2021 21:00:07 -0800 [thread overview]
Message-ID: <e401bb98-6b39-b148-fdba-76e48c7c3932@linux.microsoft.com> (raw)
In-Reply-To: <3fdb72ae-f291-386b-e7b9-688dfe092dc5@linux.microsoft.com>
<snip>
>>> void process_buffer_measurement(struct inode *inode, const void
>>> *buf, int size,
>>> const char *eventname, enum ima_hooks func,
>>> - int pcr, const char *func_data);
>>> + int pcr, const char *func_data,
>>> + bool measure_buf_hash);
>>
>> Please abbreviate the boolean name to "hash". The test would then be
>> "if (hash == true)" or "if (hash)".
>>
> Will do.
<snip>
>>> - * process_buffer_measurement - Measure the buffer to ima log.
>>> + * process_buffer_measurement - Measure the buffer or the buffer
>>> data hash
>>> * @inode: inode associated with the object being measured (NULL
>>> for KEY_CHECK)
>>> * @buf: pointer to the buffer that needs to be added to the log.
>>> * @size: size of buffer(in bytes).
>>> @@ -787,12 +787,23 @@ int ima_post_load_data(char *buf, loff_t size,
>>> * @func: IMA hook
>>> * @pcr: pcr to extend the measurement
>>> * @func_data: private data specific to @func, can be NULL.
>>> + * @measure_buf_hash: measure buffer hash
>>
>> ^@hash: measure buffer data hash
>>
> Agreed. Will fix.
<snip>
>>> void process_buffer_measurement(struct inode *inode, const void
>>> *buf, int size,
>>> const char *eventname, enum ima_hooks func,
>>> - int pcr, const char *func_data)
>>> + int pcr, const char *func_data,
>>> + bool measure_buf_hash)
>>> {
>>> int ret = 0;
>>> const char *audit_cause = "ENOMEM";
>>> @@ -807,6 +818,8 @@ void process_buffer_measurement(struct inode
>>> *inode, const void *buf, int size,
>>> struct ima_digest_data hdr;
>>> char digest[IMA_MAX_DIGEST_SIZE];
>>> } hash = {};
>>> + char buf_hash[IMA_MAX_DIGEST_SIZE];
>>> + int buf_hash_len = hash_digest_size[ima_hash_algo];
>>> int violation = 0;
>>> int action = 0;
>>> u32 secid;
>>> @@ -849,13 +862,27 @@ void process_buffer_measurement(struct inode
>>> *inode, const void *buf, int size,
>>> goto out;
>>> }
>>> + if (measure_buf_hash) {
>>
>> ^ if (hash) {
> Yes.
>>> + memcpy(buf_hash, hash.hdr.digest, buf_hash_len);
>>> +
>>> + ret = ima_calc_buffer_hash(buf_hash, buf_hash_len,
>>> + iint.ima_hash);
>>> + if (ret < 0) {
>>> + audit_cause = "measure_buf_hash_error";
Hi Mimi,
There already exist a local struct variable named "hash" in p_b_m().
I was thinking of using "buf_hash", but that one is taken too.
Maybe I should use "buf_hash" for the input bool, and rename the
existing "buf_hash" local variable to "digest_hash"?
Does it sound ok?
Thanks,
Tushar
<snip>
next prev parent reply other threads:[~2021-01-06 5:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-12 18:02 [PATCH v9 0/8] IMA: support for measuring kernel integrity critical data Tushar Sugandhi
2020-12-12 18:02 ` [PATCH v9 1/8] IMA: generalize keyring specific measurement constructs Tushar Sugandhi
2020-12-24 13:06 ` Mimi Zohar
2021-01-05 18:48 ` Tushar Sugandhi
2020-12-12 18:02 ` [PATCH v9 2/8] IMA: add support to measure buffer data hash Tushar Sugandhi
2020-12-24 0:03 ` Mimi Zohar
2021-01-05 18:53 ` Tushar Sugandhi
2021-01-06 5:00 ` Tushar Sugandhi [this message]
2020-12-12 18:02 ` [PATCH v9 3/8] IMA: define a hook to measure kernel integrity critical data Tushar Sugandhi
2020-12-24 13:04 ` Mimi Zohar
2021-01-05 20:01 ` Tushar Sugandhi
2021-01-05 20:16 ` Mimi Zohar
2021-01-05 20:19 ` Tushar Sugandhi
2020-12-12 18:02 ` [PATCH v9 4/8] IMA: add policy rule to measure " Tushar Sugandhi
2020-12-12 19:20 ` Tyler Hicks
2020-12-13 1:21 ` Tushar Sugandhi
2020-12-24 13:48 ` Mimi Zohar
2021-01-05 20:12 ` Tushar Sugandhi
2020-12-12 18:02 ` [PATCH v9 5/8] IMA: limit critical data measurement based on a label Tushar Sugandhi
2020-12-12 19:20 ` Tyler Hicks
2020-12-13 1:21 ` Tushar Sugandhi
2020-12-24 14:29 ` Mimi Zohar
2021-01-05 20:28 ` Tushar Sugandhi
2020-12-12 18:02 ` [PATCH v9 6/8] IMA: extend critical data hook to limit the " Tushar Sugandhi
2020-12-12 18:02 ` [PATCH v9 7/8] IMA: define a builtin critical data measurement policy Tushar Sugandhi
2020-12-24 14:41 ` Mimi Zohar
2021-01-05 20:30 ` Tushar Sugandhi
2020-12-12 18:02 ` [PATCH v9 8/8] selinux: include a consumer of the new IMA critical data hook Tushar Sugandhi
2020-12-23 21:10 ` Paul Moore
2021-01-04 23:30 ` Lakshmi Ramasubramanian
2021-01-05 2:13 ` Paul Moore
2021-01-05 5:24 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e401bb98-6b39-b148-fdba-76e48c7c3932@linux.microsoft.com \
--to=tusharsu@linux.microsoft.com \
--cc=agk@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=paul@paul-moore.com \
--cc=sashal@kernel.org \
--cc=selinux@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=stephen.smalley.work@gmail.com \
--cc=tyhicks@linux.microsoft.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).