From: Faiz Abbas <faiz_abbas@ti.com>
To: Michal Simek <michal.simek@xilinx.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-mmc@vger.kernel.org>
Cc: <ulf.hansson@linaro.org>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <adrian.hunter@intel.com>,
<kishon@ti.com>
Subject: Re: [PATCH 2/3] dt-bindings: mmc: sdhci-of-arasan: Add deprecated message for am654
Date: Mon, 3 Dec 2018 13:33:50 +0530 [thread overview]
Message-ID: <e431f6f8-3c8d-3540-3d21-d3e9aa292574@ti.com> (raw)
In-Reply-To: <6f4734e6-8238-2e14-ae11-114e396df75c@xilinx.com>
Hi Michal,
On 30/11/18 12:48 PM, Michal Simek wrote:
> On 29. 11. 18 17:15, Faiz Abbas wrote:
>> The "ti,am654-sdhci-5.1" binding has been moved to a new driver. Indicate
>> this by a deprecated message.
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>> ---
>> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> index e2effe17f05e..1edbb049cccb 100644
>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> @@ -16,6 +16,10 @@ Required Properties:
>> - "rockchip,rk3399-sdhci-5.1", "arasan,sdhci-5.1": rk3399 eMMC PHY
>> For this device it is strongly suggested to include arasan,soc-ctl-syscon.
>> - "ti,am654-sdhci-5.1", "arasan,sdhci-5.1": TI AM654 MMC PHY
>> + Note: This binding has been deprecated and moved to [5].
>> +
>> + [5] Documentation/devicetree/bindings/mmc/sdhci-am654.txt
>> +
>> - reg: From mmc bindings: Register location and length.
>> - clocks: From clock bindings: Handles to clock inputs.
>> - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
>>
>
> I would prefer if you can extend commit message by description you have
> in cover letter which explains reasons. When this is applied and someone
> look at git history none will understand from first read why you have
> done that.
>
Ok. Will add full explanations to both documentation patches.
Thanks,
Faiz
next prev parent reply other threads:[~2018-12-03 8:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 16:15 [PATCH 0/3] Add driver Support for MMCSD on AM654x Faiz Abbas
2018-11-29 16:15 ` [PATCH 1/3] dt-bindings: mmc: sdhci-am654: Document bindings for the host controllers on TI's AM654 SOCs Faiz Abbas
2018-11-29 16:15 ` [PATCH 2/3] dt-bindings: mmc: sdhci-of-arasan: Add deprecated message for am654 Faiz Abbas
2018-11-30 7:18 ` Michal Simek
2018-12-03 8:03 ` Faiz Abbas [this message]
2018-11-29 16:15 ` [PATCH 3/3] mmc: sdhci_am654: Add Initial Support for AM654 SDHCI driver Faiz Abbas
2018-12-05 13:42 ` Adrian Hunter
2018-12-05 15:07 ` Faiz Abbas
2018-12-07 13:32 ` Adrian Hunter
2018-12-10 12:04 ` Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e431f6f8-3c8d-3540-3d21-d3e9aa292574@ti.com \
--to=faiz_abbas@ti.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).