From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: <linux@roeck-us.net>, <wim@linux-watchdog.org>,
<geert+renesas@glider.be>, <linux-watchdog@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Phil Edworthy <phil.edworthy@renesas.com>
Subject: Re: [PATCH v5 2/2] watchdog: Add Renesas RZ/N1 Watchdog driver
Date: Wed, 13 Apr 2022 09:55:39 +0200 [thread overview]
Message-ID: <e433c3b8-5118-47ad-0cfd-8ca79acbf7e0@traphandler.com> (raw)
In-Reply-To: <YlOJVzA49rTrBDH3@google.com>
On 11/04/2022 03:50, Tzung-Bi Shih wrote:
> On Fri, Apr 08, 2022 at 10:02:05PM +0200, Jean-Jacques Hiblot wrote:
>> From: Phil Edworthy <phil.edworthy@renesas.com>
>>
>> This is a driver for the standard WDT on the RZ/N1 devices. This WDT has
>> very limited timeout capabilities. However, it can reset the device.
>> To do so, the corresponding bits in the SysCtrl RSTEN register need to
>> be enabled. This is not done by this driver.
>>
>> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> With a minor comment:
> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Thanks for the time you took reviewing this.
>
>> +static int rzn1_wdt_probe(struct platform_device *pdev)
>> +{
> [...]
>> + wdt->wdtdev.timeout = DEFAULT_TIMEOUT;
>> + ret = watchdog_init_timeout(&wdt->wdtdev, 0, dev);
> Could it drop the assignment if `ret` is unused?
I'll keep the assignment but check the value: watchdog_timeout_invalid()
will return an error if the dt supplied value is out of range.
JJ
prev parent reply other threads:[~2022-04-13 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 20:02 [PATCH v5 0/2] ARM: r9a06g032: add support for the watchdogs Jean-Jacques Hiblot
2022-04-08 20:02 ` [PATCH v5 1/2] dt-bindings: watchdog: renesas,wdt: Add support for RZ/N1 Jean-Jacques Hiblot
2022-04-08 20:02 ` [PATCH v5 2/2] watchdog: Add Renesas RZ/N1 Watchdog driver Jean-Jacques Hiblot
2022-04-11 1:50 ` Tzung-Bi Shih
2022-04-11 2:43 ` Guenter Roeck
2022-04-13 7:55 ` Jean-Jacques Hiblot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e433c3b8-5118-47ad-0cfd-8ca79acbf7e0@traphandler.com \
--to=jjhiblot@traphandler.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=phil.edworthy@renesas.com \
--cc=tzungbi@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).